Add validations for case names, dates, and download URLs in _sanity_check#1519
Open
Luis-manzur wants to merge 3 commits into
Open
Add validations for case names, dates, and download URLs in _sanity_check#1519Luis-manzur wants to merge 3 commits into
Luis-manzur wants to merge 3 commits into
Conversation
…ad URLs in _sanity_check
Contributor
|
Looks like we added validation for url endings --- can we remove this please and focus just on the validation for dates |
Contributor
|
I think I would want to add more tests and do further research into the other components and I think it complicates this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new validations to the
_check_sanitymethod inAbstractSiteto enhance data integrity checks and improve error handling.Enhancements to
_check_sanityvalidations:download_urlsusing a regular expression to detect potentially unsafe or unexpected file types.case_names, logging warnings when detected.case_datesare not earlier than the year 1900, raising an exception for invalid dates.