Skip to content

feat: add QR code for room join#26

Open
ShubhamSPawade wants to merge 5 commits into
freeman-jiang:mainfrom
ShubhamSPawade:main
Open

feat: add QR code for room join#26
ShubhamSPawade wants to merge 5 commits into
freeman-jiang:mainfrom
ShubhamSPawade:main

Conversation

@ShubhamSPawade

Copy link
Copy Markdown

Adds a QR code modal to share the room URL for easier multi-device joining.

  • Displays a QR code with the full room link (https://www.beatsync.gg/room/<roomId>)
  • Adds a "Show QR Code" button on the room page
  • Opens a modal with the QR code and a message below it
  • Allows quick device joining by scanning the code

Benefits : Enables fast, error-free room joining across devices

preview1

@vercel

vercel Bot commented May 7, 2025

Copy link
Copy Markdown

@ShubhamSPawade is attempting to deploy a commit to the freemanjiang's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ShubhamSPawade

Copy link
Copy Markdown
Author

Hi! @freeman-jiang 👋, Just wanted to follow up on this PR. QR code joining is a small but powerful feature that really improves the multi-device experience. Would love to get your thoughts — I believe it's a must-have for seamless syncing. Thanks!

@MalTeeez

MalTeeez commented May 8, 2025

Copy link
Copy Markdown

@ShubhamSPawade looks awesome, could you maybe switch the url with one derived from the providers url, i.e. just from window.location.href to support multiple instances.

@ShubhamSPawade

ShubhamSPawade commented May 8, 2025

Copy link
Copy Markdown
Author

Hey! @MalTeeez My first PR should totally get merged in 😅 — it's a small addition but really improves multi-device syncing. I’ll update the QR code to use window.location.origin instead of the hardcoded URL so it supports self-hosted instances too. Will push that shortly!

@freeman-jiang freeman-jiang left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort, but needs a lot more polish before it's ready.

Comment thread apps/client/src/components/room/TopBar.tsx Outdated
Comment thread apps/client/src/components/room/TopBar.tsx Outdated
Comment thread apps/client/src/components/QRCodeModal.tsx
Comment thread apps/client/src/components/room/TopBar.tsx Outdated
@ShubhamSPawade

Copy link
Copy Markdown
Author

@freeman-jiang done with the changes.. please take a review

@ShubhamSPawade

Copy link
Copy Markdown
Author

@freeman-jiang done with the changes.. please take a review

@freeman-jiang

Copy link
Copy Markdown
Owner

Please resolve conflicts and merge with main, would also be good if you can include an updated screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants