Skip to content

[TASK] Add node.owner filter; auto-select nodes tab for filter URLs#300

Open
psi-4ward wants to merge 3 commits intofreifunk:mainfrom
psi-4ward:feat/owner-filter
Open

[TASK] Add node.owner filter; auto-select nodes tab for filter URLs#300
psi-4ward wants to merge 3 commits intofreifunk:mainfrom
psi-4ward:feat/owner-filter

Conversation

@psi-4ward
Copy link
Copy Markdown

Description

  • Add node.owner as a filterable property in the proportions panel.
  • Make the owner/contact field in the node infobox clickable to filter by that owner.
  • Auto-select the nodes tab on page load when URL filter parameters are present.
  • Add locale strings for the new filter (de, en, fr, cz, ru, tr), (generated by AI).

Motivation and Context

There was no way to filter nodes by owner/contact. This makes the contact field actionable and adds owner as a first-class filter. The auto-tab-switch ensures shared filter URLs land on the correct tab. Now a node-maintainer can generate a perm-link to all it's nodes.

How Has This Been Tested?

  • Used ffmuc data
  • Manually clicked owner link in node infobox, confirmed filter is applied and nodes tab is selected.
  • Loaded URL with filter params, confirmed nodes tab is auto-selected.

Screenshots/links:

image image

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@maurerle
Copy link
Copy Markdown
Member

maurerle commented Feb 22, 2026

Thanks! I like this feature (to have a link to all nodes by owner).
However, I think that it is not good to have a filter by clicking on the node infobox for just one fields (as it adds a new UX). This also differs from the mailto action performed before, right?

I also would not like to list all addresses in the statistics tab somehow (which would fit the existing filtering UX).

So I am not quite sure where to go from here.
It has been suggested to filter from infobox entries (I guess with a button next to the entry) in #83, so I guess it would be good to add this option consistently to all fields.
What do you think?

@psi-4ward
Copy link
Copy Markdown
Author

psi-4ward commented Feb 22, 2026

This also differs from the mailto action performed before, right?

The owner field is not validated against a E-Mail. At least for ffmuc there is no mailto-href yet.

Making some more fields filterable is a good idea (but not all - ie Mac, runtime, etc). So u suggets just add some more "clickable" attributes as filters here?


Btw: Blocking a PR by enforcing npm audit is wise. It's off-topic for a feature / bugfix change and should be addressed separately.

@maurerle
Copy link
Copy Markdown
Member

Thanks, I remembered that wrong.

I don't really like to have some fields filtering and some fields doing other things. So I would suggest to have a filter button next to the attributes which can be filtered..?

@grische also once mentioned to have a small button next to entries to copy an entry (like the ipv6) hasslefree to the clipboard..
I am still undecided where to go from here and would like to hear other opinions.

Yes the npm audit is independent of this PR, so all good.

@maurerle
Copy link
Copy Markdown
Member

I would prefer have a funnel icon on the right next to firmware version, gluon version, contact and hardware model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants