Add embed.js to Dockerfile#405
Conversation
d5ad2e0 to
9db23a1
Compare
|
Preview deployed: https://freifunk.github.io/meshviewer/pr-preview/pr-405/ Updated for commit 0a02491. |
9db23a1 to
0a02491
Compare
|
I'm not quite sure about this. Do i understand correctly that you want to load <meshviewer_url>/embed.js in your parent page? As i understand it the embed.js is used to synchronize the URL of the parent with the child, which makes sense during development / debugging. What would be the use case for embedding meshviewer but still synchronizing the parent URL? I'm not against merging this, i would just like to understand / get more context before approving. |
|
We have https://karte.freifunk-leipzig.de/#/de/map (meshviewer) and https://freifunk-leipzig.de/map/ (Website with meshviewer in iframe). The embed feature (allready merged) allows to deep-link from the website into the map and also update the map url hashes on the website. I thought about the options:
While 1st would be the easy/fast way, it has several drawbacks: |
Description
Adds embed.js to the docker image
Motivation and Context
Deliver embed.js along with meshviewer, so that embedding pages can refer to the version that blongs to this meshviewer version.
How Has This Been Tested?
Only reviewed (just adds 1 file to the docker image)
Screenshots/links:
Checklist: