Fix placeholders in Finnish translation#1166
Conversation
📝 WalkthroughWalkthroughThe Finnish translations file ChangesFinnish translation updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
I made this as a PR, but I suppose fixes should really come through WebLate. Right? I tried to use it, but it said that it is temporarily closed for maintenance. Finnish language in the translation should be improved (a lot), but I did not touch to it here. |
|
|
Rebased. |
frenckatron
added
the
bugfix
Returned translated placeholders to English. Fixes the issue frenck#1165.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 61.15% 61.18% +0.03%
==========================================
Files 119 119
Lines 3035 3035
Branches 390 390
==========================================
+ Hits 1856 1857 +1
+ Misses 1133 1132 -1
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frenck
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
custom_components/spook/translations/fi.json (1)
225-294: 💤 Low valueConsider making link text language consistent.
The link text in issue descriptions mixes English and Finnish:
- Automation/dashboard issues use English:
[edit the automation],[edit the dashboard]- Scene/script issues use Finnish:
[muokkaa kohtausta],[muokkaa komentosarjaa]For a better user experience, consider translating all link text to Finnish consistently, e.g., change
[edit the automation]to[muokkaa automaatiota]and[edit the dashboard]to[muokkaa kojelautaa].Note: This is outside the scope of placeholder standardization and can be addressed separately if desired.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@custom_components/spook/translations/fi.json` around lines 225 - 294, The link text in several translation entries mixes English and Finnish; update the link display text to Finnish for consistency by changing English phrases like "[edit the automation]" and "[edit the dashboard]" to Finnish equivalents (e.g., "[muokkaa automaatiota]" and "[muokkaa kojelautaa]") where they appear in keys such as automation_unknown_area_references, automation_unknown_device_references, automation_unknown_entity_references, automation_unknown_floor_references, automation_unknown_label_references, automation_unknown_service_references, lovelace_unknown_entity_references, scene_unknown_entity_references, script_unknown_area_references, script_unknown_device_references, script_unknown_entity_references, script_unknown_floor_references, script_unknown_label_references so the link text language is consistent across all descriptions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@custom_components/spook/translations/fi.json`:
- Around line 225-294: The link text in several translation entries mixes
English and Finnish; update the link display text to Finnish for consistency by
changing English phrases like "[edit the automation]" and "[edit the dashboard]"
to Finnish equivalents (e.g., "[muokkaa automaatiota]" and "[muokkaa
kojelautaa]") where they appear in keys such as
automation_unknown_area_references, automation_unknown_device_references,
automation_unknown_entity_references, automation_unknown_floor_references,
automation_unknown_label_references, automation_unknown_service_references,
lovelace_unknown_entity_references, scene_unknown_entity_references,
script_unknown_area_references, script_unknown_device_references,
script_unknown_entity_references, script_unknown_floor_references,
script_unknown_label_references so the link text language is consistent across
all descriptions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a3fd2b3d-4a70-480e-bdfc-95b5fa3fcc97
📒 Files selected for processing (1)
custom_components/spook/translations/fi.json
frenckatron
left a comment
frenckatron
left a comment
There was a problem hiding this comment.
Reviewed the Finnish placeholder fixes and refreshed the branch against current main.
The changes restore placeholder names to the source-language contract. Placeholder parity with en.json is clean and CI is green.
../Frenckatron
The robot version of Frenck.
Blogging my personal ramblings at frenck.dev
4 participants
Returned translated placeholders to English.
Fixes the issue #1165.
Description
Placeholders were incorrectly also translated to Finnish which should not happen.
How has this been tested?
I installed the language file to my system and re-checked logs. No log writings any more.
Types of changes
Checklist