Skip to content

Introduce API v1alpha11#151

Merged
stefan-brus-frequenz merged 1 commit into
frequenz-floss:v0.x.xfrom
stefan-brus-frequenz:v1alpha11
Jan 26, 2026
Merged

Introduce API v1alpha11#151
stefan-brus-frequenz merged 1 commit into
frequenz-floss:v0.x.xfrom
stefan-brus-frequenz:v1alpha11

Conversation

@stefan-brus-frequenz
Copy link
Copy Markdown
Collaborator

Replaces #146

This PR clarifies resampling and streaming semantics of the Reporting API. The primary focus of this change is documentation correctness and consistency. Some breaking API changes are introduced.

Key improvements:

Resampling is now explicitly defined as time-grid materialization over telemetry data, applied to both historical and real-time streams.
sample_time semantics are clarified:
origin time when not resampled,
interval start when resampled.
Resampled streams are time-keyed upsert streams:
metric values may be unset if no data contributed to an interval,
intervals may be re-emitted with updated values when late telemetry arrives.
Examples and field documentation were updated to reflect:
empty values,
interval-based timestamps,
non-append-only behavior.
Some schema or wire-format changes were made.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces API version v1alpha11 of the Frequenz Reporting Service, focusing on clarifying and improving the documentation of resampling and streaming semantics. The primary goal is to enhance documentation correctness and consistency while introducing some breaking API changes.

Changes:

  • Clarified resampling semantics: explicitly defined as time-grid materialization with interval-based timestamps and upsert stream behavior
  • Updated sample_time semantics to represent origin time when not resampled, interval start when resampled
  • Changed TimeFilter message to use frequenz.api.common.v1alpha8.types.Interval instead of separate start_time and end_time fields
  • Renamed service from Reporting to ReportingService to align with other Frequenz services
  • Enhanced documentation with examples showing empty values, interval-based timestamps, and non-append-only behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.

File Description
proto/frequenz/api/reporting/v1alpha11/reporting.proto New API version introducing comprehensive documentation updates for resampling and streaming semantics, service renaming, and TimeFilter restructuring
RELEASE_NOTES.md Added release notes documenting the new v1alpha11 API version and its changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Comment thread proto/frequenz/api/reporting/v1alpha11/reporting.proto Outdated
Copy link
Copy Markdown
Contributor

@cwasicki cwasicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is copied as-is from #146, this LGTM. The copilot comments look reasonable on first glimpse.

Copy link
Copy Markdown
Contributor

@thomas-nicolai-frequenz thomas-nicolai-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Stefan Brus <stefan.brus@frequenz.com>
Copy link
Copy Markdown
Contributor

@cwasicki cwasicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefan-brus-frequenz stefan-brus-frequenz added this pull request to the merge queue Jan 26, 2026
Merged via the queue into frequenz-floss:v0.x.x with commit 8cac5ae Jan 26, 2026
6 checks passed
@stefan-brus-frequenz stefan-brus-frequenz deleted the v1alpha11 branch January 26, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:proto Affects the protocol buffer definition files part:python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants