Convert timestamp to UTC#132
Merged
matthias-wende-frequenz merged 1 commit intoApr 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request converts timestamp handling to UTC by introducing a new helper function.
- Added dt_to_pb_timestamp_utc that validates timezone-aware datetime objects and converts them to UTC.
- Replaced existing calls to dt_to_pb_timestamp with the new UTC-aware function.
Comments suppressed due to low confidence (1)
src/frequenz/client/electricity_trading/_client.py:1023
- Since 'datetime' is imported directly from the datetime module, consider using 'datetime' instead of 'datetime.datetime' for the isinstance check.
if not isinstance(dt, datetime.datetime):
1a75041 to
bff51d9
Compare
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
bff51d9 to
3eb29a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.