Ensure timestamp conversion errors are surfaced#133
Merged
matthias-wende-frequenz merged 2 commits intoApr 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that errors during timestamp conversion in the electricity trading client are surfaced immediately by adding a try...except...raise block. Key changes include:
- Introducing a try-except block around dt_to_pb_timestamp_utc calls for start_time and end_time.
- Updating the client code to use the converted timestamp variables.
- Reflecting the change in RELEASE_NOTES.md for clarity on how timestamp conversion errors are handled.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frequenz/client/electricity_trading/_client.py | Wraps timestamp conversion with try...except...raise to propagate errors immediately. |
| RELEASE_NOTES.md | Updates release notes to include the new behavior on timestamp conversion errors. |
98a619e to
78a1fa6
Compare
micaebe
previously approved these changes
Apr 23, 2025
micaebe
reviewed
Apr 23, 2025
Explicitly call `dt_to_pb_timestamp_utc` for start_time and end_time. Previously, an error during this conversion might not have been handled explicitly at this point. This change guarantees that if the conversion fails, the exception is propagated immediately, improving robustness and aiding debugging by making the failure point clear. Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
Signed-off-by: Matthias Wende <matthias.wende@frequenz.com>
78a1fa6 to
3341926
Compare
Contributor
Author
Now all nox tests are passing 🥳. |
micaebe
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a try...except...raise block around the calls to
dt_to_pb_timestamp_utcfor start_time and end_time.Previously, an error during this conversion might not have been handled explicitly at this point. This change guarantees that if the conversion fails, the exception is propagated immediately, improving robustness and aiding debugging by making the failure point clear.