Keep retrying on client connection error#10
Merged
Conversation
When a streaming method was returning immediately, the client exited leading to the logical meter exiting as well. This commit fixes it. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where client connection errors were causing the logical meter to exit prematurely. The change removes error propagation from the stream handling functions, allowing the system to continue running and retry connections instead of terminating when streaming methods return immediately due to connection failures.
- Converted
start_electrical_component_telemetry_streamfrom returningResult<(), Error>to returning() - Replaced error propagation with logging and early returns for connection failures
- Updated callers to not propagate errors from the streaming function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shsms
added
the
cmd:skip-release-notes
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a streaming method was returning immediately, the client exited
leading to the logical meter exiting as well.
This PR fixes it.