Retry on missing server at startup#36
Merged
Merged
Conversation
Expose combine_parallel, intersect, and merge_if_overlapping on Bounds so external callers can reuse them. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Replace the eager Channel::connect call in MicrogridClientHandle::try_new with Endpoint::connect_lazy, so a missing server at startup no longer causes the calling app to exit immediately. Connection errors now surface per-RPC, where the actor's existing per-stream retry loop can recover once the server becomes reachable. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Wrap the entire fetch-and-build sequence (list components, list connections, build the component graph) in a single retry loop that sleeps 3 seconds between attempts and keeps trying until it succeeds. This way, transient API failures and graph-build errors stemming from incomplete server-side data both clear themselves up without aborting the calling app at startup. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
matthias-wende-frequenz
approved these changes
May 8, 2026
matthias-wende-frequenz
left a comment
matthias-wende-frequenz
left a comment
There was a problem hiding this comment.
approved under promise that there will be a jitter or exponential backoff follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently microgrid-rs retries when an existing connection is lost, but when there's not server available at startup, it exits immediately.
This PR changes that:
MicrogridClientHandle::try_newreturns immediately with a lazily established connection to the API.LogicalMeterHandle::try_newawaits until a server is available, so that it can build the a component graph.