Prepare for release#37
Conversation
The graph crate's `ComponentGraphConfig` switched from a struct literal to a builder, and grew several new policy knobs whose defaults differ from the values that were previously hardcoded inside `build_component_graph` (`allow_component_validation_failures`, `allow_unconnected_components`, plus the new `prefer_meters_in_component_formulas` and `include_phantom_loads_in_consumer_formula`). Add a `component_graph_config` field on `LogicalMeterConfig`, settable via `with_component_graph_config`, defaulting to `ComponentGraphConfig::default()`. `build_component_graph` now takes `&ComponentGraphConfig` from that field, so callers can pin whichever behavior they need without further plumbing changes. The two formula-pinning tests build a `ComponentGraphConfig` inline so their expected formula strings and resampled values stay valid. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Also include some documentation fixes. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
force-pushed
the
prepare-for-release
branch
from
b513c89 to
1744d5b
Compare
simonvoelcker
left a comment
simonvoelcker
left a comment
There was a problem hiding this comment.
Just nitpicks / questions
|
|
||
| For more information, please visit the [documentation | ||
| website](https://docs.rs/frequenz-microgrid). | ||
| Support for controlling components is coming soon. |
There was a problem hiding this comment.
Announcements like this one usually don't age well, in my experience. And why ourselves under pressure? 😏
There was a problem hiding this comment.
Oh, because microgrid-rs is supposed to read and control. This lets them know that it is not there yet. Also, this is the next big thing for me, multiple things are blocked until we get this.
| check out the [Contributing Guide](CONTRIBUTING.md). | ||
| See the [Contributing Guide](https://github.com/frequenz-floss/frequenz-microgrid-rs/blob/HEAD/CONTRIBUTING.md). | ||
|
|
||
| [`ComponentGraph`]: https://docs.rs/frequenz-microgrid-component-graph/latest/frequenz_microgrid_component_graph/struct.ComponentGraph.html |
There was a problem hiding this comment.
What is this list of docs links about? It does not look related to "Contributing", the previous headline ...?
There was a problem hiding this comment.
No, they're the link references. So all occurrences of [ComponentGraph] in the text above will point to this link.
There was a problem hiding this comment.
And don't show up in the rendered markdown.
2 participants
No description provided.