Use the new private ARM runner for private repositories#413
Closed
llucax wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
We used to use the same name for our private ARM runner as the public one from GitHub, so we could easily re-use the same workflow for private and public repos. This doesn't work anymore because GitHub now randomly picks any runner with that name, and if it is a public one, then it will refuse to run for private repos. Because of this we now use the suffix `-arm64` for our private ARM runner, and we target the right runner based on the `github.repository_visibility` context variable. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
Bot
added
the
part:template
Contributor
Author
|
Ready for review, but based on #412, so only the last commit is relevant. |
Contributor
Author
|
We took sooooooooo long to complete this that even GitHub was faster than us to fix it 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to use the same name for our private ARM runner as the public one from GitHub, so we could easily re-use the same workflow for private and public repos. This doesn't work anymore because GitHub now randomly picks any runner with that name, and if it is a public one, then it will refuse to run for private repos. Because of this we now use the suffix
-arm64for our private ARM runner, and we target the right runner based on thegithub.repository_visibilitycontext variable.