Extract stop() method into AbstractPoolReferenceStore

Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>

Author: simonvoelcker

src/frequenz/sdk/timeseries/abstract_pool/_abstract_pool_reference_store.py

@@ -124,3 +124,10 @@ def get_namespace(self) -> str:
     @abstractmethod
     def create_bounds_tracker(self) -> None:
         """Create the bounds tracker for the pool."""
+
+    async def stop(self) -> None:
+        """Stop all tasks and channels."""
+        await self.formula_pool.stop()
+        if self.bounds_tracker is not None:
+            await self.bounds_tracker.stop()
+        self.status_receiver.close()

src/frequenz/sdk/timeseries/battery_pool/_battery_pool_reference_store.py

@@ -94,12 +94,10 @@ def __init__(  # pylint: disable=too-many-arguments
         self._batteries = self.component_ids
         self._working_batteries: set[ComponentId] = set()
         self._update_battery_status_task: asyncio.Task[None] | None = None
-        self._batteries_status_receiver: Receiver[ComponentPoolStatus] = (
-            batteries_status_receiver
-        )
+
         if self._batteries:
             self._update_battery_status_task = asyncio.create_task(
-                self._update_battery_status(self._batteries_status_receiver)
+                self._update_battery_status(self.status_receiver)
             )
         self._min_update_interval: timedelta = min_update_interval
         self._active_methods: dict[str, MetricAggregator[Any]] = {}
@@ -130,15 +128,15 @@ def create_bounds_tracker(self) -> None:
         """Create the bounds tracker for the pool."""
 
     async def stop(self) -> None:
-        """Stop all pending async tasks."""
+        """Stop all tasks and channels."""
+        await super().stop()
+
         tasks_to_stop: list[Awaitable[Any]] = [
             method.stop() for method in self._active_methods.values()
         ]
-        tasks_to_stop.append(self.formula_pool.stop())
         if self._update_battery_status_task:
             tasks_to_stop.append(cancel_and_await(self._update_battery_status_task))
         await asyncio.gather(*tasks_to_stop)
-        self._batteries_status_receiver.close()
 
     async def _update_battery_status(
         self, receiver: Receiver[ComponentPoolStatus]

src/frequenz/sdk/timeseries/ev_charger_pool/_ev_charger_pool_reference_store.py

@@ -55,10 +55,3 @@ def create_bounds_tracker(self) -> None:
             self.bounds_channel.new_sender(),
         )
         self.bounds_tracker.start()
-
-    async def stop(self) -> None:
-        """Stop all tasks and channels owned by the EVChargerPool."""
-        await self.formula_pool.stop()
-        if self.bounds_tracker is not None:
-            await self.bounds_tracker.stop()
-        self.status_receiver.close()

src/frequenz/sdk/timeseries/pv_pool/_pv_pool_reference_store.py

@@ -57,10 +57,3 @@ def create_bounds_tracker(self) -> None:
                 self.bounds_channel.new_sender(),
             )
             self.bounds_tracker.start()
-
-    async def stop(self) -> None:
-        """Stop all tasks and channels owned by the PVInverterPool."""
-        await self.formula_pool.stop()
-        if self.bounds_tracker is not None:
-            await self.bounds_tracker.stop()
-        self.status_receiver.close()