Allow inline migration scripts#11
Merged
Merged
Conversation
Support embedding the migration script in the workflow YAML via the `migration-script` input, as an alternative to fetching it from `script-url-template`. This reduces setup overhead for small, trusted migrations while keeping the existing `pull_request_target` safety model. Inline scripts are written to a temporary file and executed with `python3 -I` once per version. The target is provided as `MIGRATION_VERSION` in both inline and URL modes, and only the `migration-token` input is exposed as GitHub credentials. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
requested review from
tiyash-basu-frequenz
and removed request for
a team
Contributor
Author
|
Seems to work well with: |
Contributor
Author
|
Will force-merge to unlock: We can address any issue in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support embedding the migration script in the workflow YAML via the
migration-scriptinput, as an alternative to fetching it fromscript-url-template. This reduces setup overhead for small, trusted migrations while keeping the existingpull_request_targetsafety model.Inline scripts are written to a temporary file and executed with
python3 -Ionce per version. The target is provided asMIGRATION_VERSIONin both inline and URL modes, and only themigration-tokeninput is exposed as GitHub credentials.This allows creating simple migration workflows for formatting and linting tools with auto-fix features, like
blackorisort.