[pull] main from git-for-windows:main#90
Merged
Conversation
This is a small documentation improvement to `AGENTS.md`. The current "Building and Testing" section only shows `make -j15` "in a Git for Windows SDK shell" and says nothing about how to drive the build when you are not sitting in an interactive SDK shell, for example from PowerShell or from an automation agent. These are two things that are easy to get wrong in that situation, so let's write them down. The first is that a login shell is the wrong tool: `bash -l` / `bash --login` re-runs the profile scripts and is unnecessary once `MSYSTEM` and `PATH` are set explicitly. Setting `MSYSTEM=MINGW64` and prepending the SDK's `mingw64\bin` and `usr\bin` directories to `PATH`, then invoking a non-login `bash -c`, is enough to get a working build environment. The second is that when the optional Rust component fails to link (`cannot find target/release/libgitcore.a`), passing `NO_RUST=1` skips the cargo step. This is expressed as a `fixup!` for the commit that introduced `AGENTS.md`, so that it autosquashes into that commit during the next merging-rebase rather than adding a separate entry to the branch thicket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )