[pull] main from git-for-windows:main#93
Merged
Conversation
vcbuild: stop hard-coding OpenSSL as a dependency Git for Windows' default SSL backend is actually Secure Channel. Let's not hard-code any backend, just ask for _any_ SSL backend. This is necessary because we cannot ask for `schannel`, as microsoft/vcpkg#46459 removed the option to specify that as a feature. Signed-off-by: Dennis Ameling <dennis@dennisameling.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
While researching a build failure in `shears/seen`, I noticed that the `vcpkg` Pipeline [has been broken since August last year](https://dev.azure.com/git/git/_build?definitionId=9&_a=summary) 🤦. The reason is that the `schannel` feature of `curl` was removed, as part of microsoft/vcpkg#46459. This PR did not remove _Secure Channel support_, it merely removed the ability to specify it _as a feature_. Let's accommodate for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )