add shorthand for name of system, change initArgs type to unknown[]#62
Open
martinemmert wants to merge 2 commits into
Open
add shorthand for name of system, change initArgs type to unknown[]#62martinemmert wants to merge 2 commits into
martinemmert wants to merge 2 commits into
Conversation
Contributor
|
Definitely have noticed some things are not quite typesafe with the use of any in a few places |
|
Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unknownis the better choice if the type-safety should be kept intact, but the arguments are unknown-> https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-0.html#new-unknown-top-type
The
sysNameis a shortcut which I introduced to save me from typingthis.constructor.namewithin my log messages all the time.