Commit f8f1aea
committed
fix(android): align directLoginAction signature with the shared JS API
The JS directLoginAction(type, data, ephemeralSession, additionalQueryParams)
signature is shared across platforms, but the Android @ReactMethod declared only
(type, data, ephemeralSession), so the trailing additionalQueryParams argument
misaligned with the Promise slot. Declare additionalQueryParams: ReadableMap? so
the JS↔native mapping matches iOS.
The native Android SDK's directLoginAction(activity, type, data) does not yet
accept ephemeralSession/additionalQueryParams (iOS does), so they remain
accepted no-ops on Android until frontegg-android-kotlin adds support. Documented
in both the Kotlin bridge and the TS API.1 parent 7500e03 commit f8f1aea
2 files changed
Lines changed: 24 additions & 1 deletion
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
140 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
141 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
142 | 157 | | |
143 | 158 | | |
144 | 159 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
46 | 54 | | |
47 | 55 | | |
48 | 56 | | |
| |||
0 commit comments