docs(android): declare applicationId before manifestPlaceholders in setup snippets#79
Merged
dianaKhortiuk-frontegg merged 1 commit intoJun 29, 2026
Conversation
…etup snippets The Android setup snippets in docs/setup.md and docs/usage.md drop `manifestPlaceholders = ["package_name": applicationId, ...]` into defaultConfig without showing applicationId above it. Customers paste the block at the top of defaultConfig, before their applicationId line; Groovy evaluates defaultConfig top-to-bottom, so applicationId resolves to null, the package_name placeholder is empty, and the AAR manifest merge fails. Match the SDK's working example apps (frontegg-android-kotlin app/embedded/ applicationId/multi-region build.gradle), which declare applicationId first and then reference it: show applicationId above the placeholders in setup.md, and tell readers in usage.md to add the block below their existing applicationId line, with an inline note on the package_name line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mykyta-frontegg
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs/setup.mdanddocs/usage.mdshow amanifestPlaceholdersblock to paste intodefaultConfig:but neither shows
applicationIddeclared above it. Groovy evaluatesdefaultConfig { }top-to-bottom, so when a customer pastes the block at the top ofdefaultConfig(before theirapplicationIdline),applicationIdresolves tonull, thepackage_nameplaceholder is empty, and the AAR manifest merge fails — a common source of integration friction.Fix
Match the SDK's working example apps (
frontegg-android-kotlinapp/embedded/applicationId/multi-regionbuild.gradle), which all declareapplicationIdfirst and then reference it inmanifestPlaceholders:applicationIdabovemanifestPlaceholders, with a comment explaining the ordering requirement.applicationIdline, with an inline note on thepackage_nameline.Docs only — no behavioral change.
🤖 Generated with Claude Code