fix(android): use reactApplicationContext.currentActivity in stepUp and openAdminPortal#83
Merged
dianaKhortiuk-frontegg merged 1 commit intoJun 30, 2026
Conversation
mykyta-frontegg
approved these changes
Jun 30, 2026
mykyta-frontegg
approved these changes
Jun 30, 2026
…nd openAdminPortal
dianaKhortiuk-frontegg
force-pushed
the
fix/android-currentactivity-stepup-adminportal
branch
from
June 30, 2026 16:38
3c4e0f1 to
45b6898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #75 ("added uses of reactApplicationContext for activities") migrated the native module's activity lookups from the bare
currentActivitytoreactApplicationContext.currentActivity, butstepUpandopenAdminPortal— added afterward in #73 and #78 — were missed and still used the bare reference, which fails to compile in consumer apps (reported on v1.2.17):This aligns both call sites with the other four (
login,directLoginAction,loginWithPasskeys,registerPasskeys), which already usereactApplicationContext.currentActivityand compile fine.Needs a patch release (1.2.18) so the customer can pick it up.