fix(android): align directLoginAction signature with the shared JS API#89
Merged
dianaKhortiuk-frontegg merged 3 commits intoJul 14, 2026
Merged
Conversation
The JS directLoginAction(type, data, ephemeralSession, additionalQueryParams) signature is shared across platforms, but the Android @ReactMethod declared only (type, data, ephemeralSession), so the trailing additionalQueryParams argument misaligned with the Promise slot. Declare additionalQueryParams: ReadableMap? so the JS↔native mapping matches iOS. The native Android SDK's directLoginAction(activity, type, data) does not yet accept ephemeralSession/additionalQueryParams (iOS does), so they remain accepted no-ops on Android until frontegg-android-kotlin adds support. Documented in both the Kotlin bridge and the TS API.
Collaborator
Author
|
Native tracking issue for the Android |
Covers the signature-alignment fix: the JS directLoginAction forwards type, data, ephemeralSession and additionalQueryParams to the native module, and defaults ephemeralSession to true when omitted.
The push workflow linted and typechecked but never ran the jest suite, so unit tests (e.g. FronteggNative bridging) were not enforced in CI. Add a Unit Tests job that runs `yarn test`.
mykyta-frontegg
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
directLoginAction@ReactMethodnow declaresadditionalQueryParams: ReadableMap?, matching the shared JS signaturedirectLoginAction(type, data, ephemeralSession, additionalQueryParams). Previously Android declared only(type, data, ephemeralSession), so the trailingadditionalQueryParamsargument misaligned with the Promise slot.Known limitation (documented, not fixed here): the native Android SDK's
directLoginAction(activity, type, data)does not yet acceptephemeralSessionoradditionalQueryParams— iOS honors both. They are therefore accepted no-ops on Android untilfrontegg-android-kotlinadds support.ephemeralSessionis inherently iOS-only here (Android runs the flow in the embedded WebView, not an ASWebAuthenticationSession browser session). Noted in the Kotlin bridge and the TS jsdoc.Tracking issue for the native gap: (filed separately).