fix: disable auto-update by default, fix update script exit code & stash leak

froooze · froooze · commit 9199b85589ea · 2026-06-25T12:25:15.000+02:00
Auto-update being ON by default is surprising and risky for a financial
system — a bot handling real funds should never silently change its code
without explicit operator opt-in.

## Update script hardening
- **Exit code 2 → 0** on "already up to date": PM2's `cron_restart`
  treats non-zero exits as failures, causing false-positive error logs
  on every successful no-op tick. (`scripts/update.ts:262`)
- **Ref-specific `git stash pop`**: captures the stash ref by message
  ("dexbot-update-auto") after push and pops by that exact ref, preventing
  cross-contamination with other stash entries. Uses `git diff
  --name-only --diff-filter=U` after pop to detect any unmerged paths
  (including asymmetric variants AU, UA, DU, UD). Logs the error object
  on failure. (`scripts/update.ts:284-332`)

## Default change
- **`UPDATER.ACTIVE: true` → `false`**: auto-update is now opt-in.
  Existing installations with `UPDATER.ACTIVE: true` in their
  `general.settings.json` are unaffected. (`modules/constants.ts:1127`)

## Chore
- Bump version to 1.0.2 via sync-version.ts (14 files across manifests,
  docs, and tests)
- Add v1.0.2 changelog entry and evolution doc update

## Testing Notes
- `npx tsx scripts/sync-version.ts --check` passes
- No behavioral change to existing tests (the test fixture explicitly
  sets `ACTIVE: true`)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.0.2] - 2026-06-25 - Auto-Update Default & Update Script Hardening
+
+### 2026-06-25
+
+- **Chore**: disable auto-update by default (`UPDATER.ACTIVE: true` → `false`) — a DEX bot handling real funds should never silently change its code without explicit operator opt-in (`modules/constants.ts:1127`).
+  - Existing installations with a pre-existing `UPDATER.ACTIVE: true` in `general.settings.json` are unaffected; the new default only applies to fresh installs or users who remove the `UPDATER` key from their settings.
+- **Fix**: exit code 2 → 0 on "already up to date" — PM2's `cron_restart` treats non-zero exits as failures, causing false-positive error logs on every successful no-op tick (`scripts/update.ts:262`).
+- **Fix**: restore stashed local changes after `git pull` with ref-specific pop — uses the exact stash ref (matched by message) instead of bare `git stash pop`, preventing cross-contamination with other stash entries. Also checks `git status --porcelain` for unmerged paths after pop and logs the error object on failure (`scripts/update.ts:299-307`).
+
 ## [1.0.1] - 2026-06-24 - Bootstrap Fill Pipeline, AccountOrders Simplification & Timer Guard
 
 ### 2026-06-24
diff --git a/analysis/ama_fitting/package.json b/analysis/ama_fitting/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ama_fitting",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Tools for fitting AMA parameters to market data",
   "main": "../../dist/analysis/ama_fitting/optimizer_high_resolution.js",
   "scripts": {
diff --git a/claw/package.json b/claw/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dexbot2-claw",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "private": true,
   "description": "Claw bridge and runtime integration layer for BitShares and DEXBot2.",
   "type": "commonjs",
diff --git a/claw/runtimes/openclaw-plugin/openclaw.plugin.json b/claw/runtimes/openclaw-plugin/openclaw.plugin.json
@@ -2,7 +2,7 @@
   "id": "bitshares-claw",
   "name": "BitShares Claw",
   "description": "Native BitShares and DEXBot2 tools from the DEXBot2 claw integration",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "skills": [
     "skills"
   ],
diff --git a/claw/runtimes/openclaw-plugin/package.json b/claw/runtimes/openclaw-plugin/package.json
@@ -1,7 +1,7 @@
 {
   "name": "bitshares-claw-openclaw-plugin",
   "private": true,
-  "version": "1.0.1",
+  "version": "1.0.2",
   "type": "commonjs",
   "main": "index.js"
 }
diff --git a/claw/tests/test_claw_mcp_transport.ts b/claw/tests/test_claw_mcp_transport.ts
@@ -30,7 +30,7 @@ async function testParserAcceptsJsonlAcrossChunksAndSingleBuffer() {
       capabilities: {},
       clientInfo: {
         name: 'claw-mcp-transport-test',
-        version: '1.0.1'
+        version: '1.0.2'
       },
       protocolVersion: '2024-11-05'
     }
@@ -181,7 +181,7 @@ async function testMainEntrypointHandlesRealProcessInitialize() {
       capabilities: {},
       clientInfo: {
         name: 'claw-mcp-transport-test',
-        version: '1.0.1'
+        version: '1.0.2'
       },
       protocolVersion: '2024-11-05'
     }
diff --git a/docs/DEXBOT_COMPARISON.md b/docs/DEXBOT_COMPARISON.md
@@ -1,7 +1,7 @@
 # DEXBot vs DEXBot2 — Detailed Comparison Report
 
 > **Date:** 2026-06-16 *(metrics refreshed against local source trees)*
-> **Scope:** Full architectural, functional, and operational comparison between the original [DEXBot](https://github.com/Codaone/DEXBot) (Python, v1.0.0) and DEXBot2 (TypeScript, v1.0.1).
+> **Scope:** Full architectural, functional, and operational comparison between the original [DEXBot](https://github.com/Codaone/DEXBot) (Python, v1.0.0) and DEXBot2 (TypeScript, v1.0.2).
 > **Audience:** Developers, contributors, and operators evaluating or migrating between the two projects.
 
 ---
@@ -36,7 +36,7 @@
 
 | Attribute | DEXBot (original) | DEXBot2 |
 |---|---|---|
-| **Release Track** | 1.0.0 | v1.0.1 |
+| **Release Track** | 1.0.0 | v1.0.2 |
 | **Language** | Python 3.6+ | TypeScript 5.x |
 | **Status** | Released 1.0.0, unmaintained | Active development |
 | **Last Repo Activity** | May 23, 2020 | 2026-06-16 |
@@ -774,7 +774,7 @@ Where:
 
 | Metric | DEXBot | DEXBot2 |
 |---|---|---|
-| **Release Track** | 1.0.0 | v1.0.1 |
+| **Release Track** | 1.0.0 | v1.0.2 |
 | **Active Since** | ~2018 | December 2025 |
 | **Last Commit** | May 23, 2020 | 2026-06-22 |
 | **Total Commits** | 2281 | 1648 at current HEAD |
diff --git a/docs/EVOLUTION.md b/docs/EVOLUTION.md
@@ -2,14 +2,14 @@
 
 ## Executive Summary
 
-DEXBot2 is a sophisticated decentralized exchange trading bot for the BitShares blockchain. This report documents the complete evolution of the project from its inception in December 2025 through the current 1.0.1 stable release.
+DEXBot2 is a sophisticated decentralized exchange trading bot for the BitShares blockchain. This report documents the complete evolution of the project from its inception in December 2025 through the current 1.0.2 stable release.
 
 ### Key Milestones
 - **Project Inception**: December 2, 2025
 - **Growth Phase**: 1,600+ commits over ~6 active months
 - **Code Maturity**: Evolution from basic utilities to a ~58,000+ LoC intelligent TypeScript system
 - **Stability**: Progression from manual testing to a suite of 200+ automated test files
-- **Releases**: 36 release entries (v0.1.0 to v1.0.1)
+- **Releases**: 37 release entries (v0.1.0 to v1.0.2)
 
 ---
 
@@ -159,13 +159,16 @@ First stable release. Profile validation, logging overhaul, AMA delta threshold,
 ### v1.0.0 → v1.0.1 (4 commits)
 Bootstrap fill pipeline refactored to use the standard same-side replacement path via `_processFillsWithBatching`, eliminating the only cross-side rotation in the codebase. AccountOrders simplified to one bot per file, removing the `{bots: {[key]: ...}}` wrapper that caused doubled-entry bugs during bot-id migration. Deferred maintenance timer guard prevents rare null/undefined spread errors during periodic blockchain fetches.
 
+### v1.0.1 → v1.0.2 (3 changes)
+Auto-update disabled by default (`ACTIVE: true` → `false`) — explicit operator opt-in required for unattended code changes on financial systems. Update script hardened: exit code 2 → 0 on "already up to date" stops PM2 false-positive error logging, and `git stash pop` added after pull to restore previously stashed uncommitted work.
+
 ---
 
 
 
 ## Development Statistics
 
-200+ automated test files (all TypeScript), 36 release entries. See **Version History** for commit breakdown by release.
+200+ automated test files (all TypeScript), 37 release entries. See **Version History** for commit breakdown by release.
 
 ---
 
@@ -207,7 +210,7 @@ DEXBot2 has matured from a basic grid bot into a signal-intelligent, production-
 ---
 
 **Report Originally Generated**: February 19, 2026
-**Last Updated**: June 24, 2026
-**Total Commits**: 1652
-**Date Range**: December 2, 2025 - June 24, 2026 (ongoing)
+**Last Updated**: June 25, 2026
+**Total Commits**: 1656
+**Date Range**: December 2, 2025 - June 25, 2026 (ongoing)
 **Repository**: DEXBot2 (BitShares DEX Trading Bot)
diff --git a/docs/FUND_MOVEMENT_AND_ACCOUNTING.md b/docs/FUND_MOVEMENT_AND_ACCOUNTING.md
@@ -825,4 +825,4 @@ To prevent "Time-of-Check to Time-of-Use" errors:
 3.  **Bootstrapping:** Fills arriving during startup (`isBootstrapping=true`) are queued until the grid is fully reconciled.
 
 ---
-*Technical Reference for DEXBot2 v1.0.1 release*
+*Technical Reference for DEXBot2 v1.0.2 release*
diff --git a/docs/README.md b/docs/README.md
@@ -2,7 +2,7 @@
 
 This directory contains the comprehensive technical documentation for the DEXBot2 trading bot. It is designed to guide developers from high-level architecture down to the nuances of fund accounting and state management.
 
-**Version context:** v1.0.1 is the current release.
+**Version context:** v1.0.2 is the current release.
 
 ---
 
@@ -108,7 +108,7 @@ This directory contains the comprehensive technical documentation for the DEXBot
 
 ### 🧭 [Evolution Report](EVOLUTION.md)
 *Project timeline and major architecture phases.*
-- **Coverage**: Historical milestones from the initial December 2025 bootstrap through the v1.0.1 stable release, including credit maintenance hardening
+- **Coverage**: Historical milestones from the initial December 2025 bootstrap through the v1.0.2 stable release, including credit maintenance hardening
 - **Focus**: Architecture evolution, release history, test growth, and documentation changes
 
 ### 🗒️ [Changelog](../CHANGELOG.md)
diff --git a/modules/constants.ts b/modules/constants.ts
@@ -1124,7 +1124,7 @@ let LOGGING_CONFIG = {
 // Updater Configuration
 let UPDATER = {
     // Whether the automated updater is enabled
-    ACTIVE: true,
+    ACTIVE: false,
     // Hardcoded repository URL
     REPOSITORY_URL: "https://github.com/froooze/DEXBot2.git",
     // Default branch policy: 'auto' (track current), 'main', 'dev', 'test'
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dexbot2",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "The first open source trading bot with zero runtime dependencies and a fully adaptive market making strategy.",
   "main": "dist/modules/chain_orders.js",
   "bin": {
diff --git a/scripts/update.ts b/scripts/update.ts
@@ -259,7 +259,7 @@ try {
             log('DEXBot2 is now tracking the correct branch.');
         }
         log('DEXBot2 is already up to date (local is equal or ahead of remote).');
-        process.exit(2);
+        process.exit(0);
     }
 
     log(`${incomingCommits} update(s) available. Proceeding with update process...`);
@@ -281,8 +281,25 @@ try {
      * Ignores gitignored directories (profiles/, dist/) — they are
      * never touched by stash, so bot configs and keys are safe.
      */
+    const STASH_MESSAGE = 'dexbot-update-auto';
+    let ourStashRef = '';
     log('Stashing local changes before pull...');
-    run('git stash push --include-untracked --message "dexbot-update-auto" 2>/dev/null; true');
+    run(`git stash push --include-untracked --message "${STASH_MESSAGE}" 2>/dev/null; true`);
+    // Capture the stash ref by message so we pop the exact entry after pull,
+    // avoiding ambiguity if any other stash operation occurs between push and pop.
+    try {
+        const list = execSync(`git stash list --format="%gd %gs" 2>/dev/null`, { stdio: 'pipe', cwd: PATHS.PROJECT_ROOT }).toString().trim();
+        if (list) {
+            for (const line of list.split('\n')) {
+                if (line.includes(STASH_MESSAGE)) {
+                    ourStashRef = line.split(' ')[0];
+                    break;
+                }
+            }
+        }
+    } catch (_) {
+        log('Debug: Could not enumerate stash list to resolve stash ref. Skipping pop.');
+    }
 
     /**
      * STEP 7: Pull Latest Code Changes
@@ -296,6 +313,28 @@ try {
     // Use --rebase to avoid merge commits and keep clean linear history
     run(`git pull --rebase origin ${branch}`);
 
+    /**
+     * Restore our stashed entry by ref (if we created one).
+     * Using the captured ref prevents accidentally popping a stash that was
+     * created by another process between push and pop.
+     */
+    if (ourStashRef) {
+        try {
+            execSync(`git stash pop ${ourStashRef}`, { stdio: 'inherit', cwd: PATHS.PROJECT_ROOT });
+            // Check for unmerged paths that git stash pop may have left behind.
+            // git diff --diff-filter=U catches all asymmetric variants (AU, UA, DU, UD)
+            // in addition to the symmetric ones (UU, AA, DD).
+            const unmerged = execSync('git diff --name-only --diff-filter=U', { stdio: 'pipe', cwd: PATHS.PROJECT_ROOT }).toString().trim();
+            if (unmerged) {
+                log('Warning: Stash pop completed with merge conflicts. Run `git status` to resolve unresolved files.');
+            }
+        } catch (err) {
+            log(`Warning: Could not restore stashed changes (merge conflicts may exist). ` +
+                `Check \`git stash list\` for "${STASH_MESSAGE}" entry.`);
+            if (err.message) log(`Details: ${err.message}`);
+        }
+    }
+
     /**
      * STEP 8: Reinstall Dependencies
      * Updates npm packages to versions specified in package-lock.json.

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ama_fitting",`
`3`		`- "version": "1.0.1",`
	`3`	`+ "version": "1.0.2",`
`4`	`4`	`"description": "Tools for fitting AMA parameters to market data",`
`5`	`5`	`"main": "../../dist/analysis/ama_fitting/optimizer_high_resolution.js",`
`6`	`6`	`"scripts": {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "dexbot2-claw",`
`3`		`- "version": "1.0.1",`
	`3`	`+ "version": "1.0.2",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "Claw bridge and runtime integration layer for BitShares and DEXBot2.",`
`6`	`6`	`"type": "commonjs",`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "bitshares-claw-openclaw-plugin",`
`3`	`3`	`"private": true,`
`4`		`- "version": "1.0.1",`
	`4`	`+ "version": "1.0.2",`
`5`	`5`	`"type": "commonjs",`
`6`	`6`	`"main": "index.js"`
`7`	`7`	`}`