fix: canonicalize error-code constants across daemon, bot client, and tests

Adds DAEMON_CODES to constants.ts (BROADCAST_DEADLINE,
CREDENTIAL_DAEMON_UNAVAILABLE) and MasterPasswordError.code static
property, replacing 12+ literal sites with single-source-of-truth
references. Follows the same pattern as the DAEMON_ERRORS fix in
0b2fdca — shared string + no canonical symbol = silent breakage.

## BROADCAST_DEADLINE
Files: credential-daemon.ts, modules/dexbot_credential_client.ts,
       tests/test_uncertain_broadcast.ts
- 7 production sites (error creation, broadcastErr.code checks,
  sendError calls) and 3 test mocks now reference
  DAEMON_CODES.BROADCAST_DEADLINE instead of the literal.
- Blast radius: 4 sender call-sites + 1 receiver + 1 receiver-fallback
  prefix + 3 mocks.

## CREDENTIAL_DAEMON_UNAVAILABLE
Files: modules/dexbot_class.ts, tests/test_fill_replay_guards.ts
- Wrapped error assignment and predicate check in _ensureCredentialDaemonWritable
  and _isCredentialDaemonError reference DAEMON_CODES.CREDENTIAL_DAEMON_UNAVAILABLE.
- Test mock updated to match.

## MASTER_PASSWORD_FAILED
Files: modules/chain_keys.ts, tests/test_chain_keys_master_password_failure.ts,
       tests/test_dexbot_start_master_password_failure_output.ts
- MasterPasswordError exposes static .code property; constructor and
  isMasterPasswordFailure predicate reference MasterPasswordError.code
  instead of the literal. Tests import and reference the static.

## Testing Notes
- test_uncertain_broadcast.ts (all 21 tests): PASS
- test_chain_keys_master_password_failure.ts: PASS
- test_dexbot_start_master_password_failure_output.ts: PASS
- test_fill_replay_guards.ts: pre-existing failure (100 !== 102.5),
  unrelated to these changes
- Build: clean compile

Author: froooze

CHANGELOG.md

@@ -10,6 +10,8 @@ All notable changes to this project will be documented in this file.
   - Existing installations with a pre-existing `UPDATER.ACTIVE: true` in `general.settings.json` are unaffected; the new default only applies to fresh installs or users who remove the `UPDATER` key from their settings.
 - **Fix**: exit code 2 → 0 on "already up to date" — PM2's `cron_restart` treats non-zero exits as failures, causing false-positive error logs on every successful no-op tick (`scripts/update.ts:262`).
 - **Fix**: restore stashed local changes after `git pull` with ref-specific pop — uses the exact stash ref (matched by message) instead of bare `git stash pop`, preventing cross-contamination with other stash entries. Also checks `git status --porcelain` for unmerged paths after pop and logs the error object on failure (`scripts/update.ts:299-307`).
+- **Fix**: align DAEMON_ERRORS string checks with canonical constants — `DaemonKeyStore` in `key_store.ts` used locally-hardcoded strings (`'SESSION_EXPIRED'`, `'SOURCE_AUTH_DENIED'`) that did not match the actual daemon error values from `constants.ts:520`, causing session refresh/retry to silently never trigger. Removed the local shadow; test mocks updated to match (`0b2fdca`).
+- **Fix**: canonicalize BROADCAST_DEADLINE, CREDENTIAL_DAEMON_UNAVAILABLE, and MASTER_PASSWORD_FAILED — adds `DAEMON_CODES` to `constants.ts` (modeled after `DAEMON_ERRORS`) and `MasterPasswordError.code` static property, replacing 12+ literal sites across the credential daemon, bot client, `dexbot_class`, `chain_keys`, and 4 test files with single-source-of-truth references to prevent silent recovery-path breakage from string drift.
 
 ## [1.0.1] - 2026-06-24 - Bootstrap Fill Pipeline, AccountOrders Simplification & Timer Guard
 

credential-daemon.ts

@@ -71,7 +71,7 @@ const { path } = require('./modules/path_api');
 const os = require('os');
 const { randomBytes } = require('./modules/crypto/sync');
 const chainKeys = require('./modules/chain_keys');
-const { TIMING, NODE_MANAGEMENT, DAEMON_ERRORS } = require('./modules/constants');
+const { TIMING, NODE_MANAGEMENT, DAEMON_ERRORS, DAEMON_CODES } = require('./modules/constants');
 const { readGeneralSettings } = require('./modules/general_settings');
 const { orderNodesForSettings } = require('./modules/node_health_cache');
 const credentialPolicy = require('./modules/credential_policy');
@@ -393,9 +393,9 @@ async function broadcastWithRetry(accountName: any, privateKey: any, broadcastFn
     const deadlinePromise = new Promise((_, reject) => {
         deadlineTimer = setTimeout(() => {
             const err: any = new Error(
-                `BROADCAST_DEADLINE:inner broadcast deadline ${innerDeadlineMs}ms exceeded`
+                `${DAEMON_CODES.BROADCAST_DEADLINE}:inner broadcast deadline ${innerDeadlineMs}ms exceeded`
             );
-            err.code = 'BROADCAST_DEADLINE';
+            err.code = DAEMON_CODES.BROADCAST_DEADLINE;
             err.uncertain = true;
             err.accountName = accountName;
             err.startedAt = startedAt;
@@ -809,7 +809,7 @@ function processRequest(requestStr: string, socket: any) {
                             (client: any) => client.broadcast(operation)
                         );
                     } catch (broadcastErr: any) {
-                        if (broadcastErr && broadcastErr.code === 'BROADCAST_DEADLINE') {
+                        if (broadcastErr && broadcastErr.code === DAEMON_CODES.BROADCAST_DEADLINE) {
                             appendAuditLog({
                                 event: 'sign_timeout',
                                 accountName,
@@ -828,7 +828,7 @@ function processRequest(requestStr: string, socket: any) {
                             return sendError(
                                 socket,
                                 'chain status uncertain after inner deadline',
-                                'BROADCAST_DEADLINE'
+                                DAEMON_CODES.BROADCAST_DEADLINE
                             );
                         }
                         throw broadcastErr;
@@ -914,7 +914,7 @@ function processRequest(requestStr: string, socket: any) {
                             (client: any) => executeOperationsWithClient(client, operations)
                         );
                     } catch (broadcastErr: any) {
-                        if (broadcastErr && broadcastErr.code === 'BROADCAST_DEADLINE') {
+                        if (broadcastErr && broadcastErr.code === DAEMON_CODES.BROADCAST_DEADLINE) {
                             appendAuditLog({
                                 event: 'sign_timeout',
                                 accountName,
@@ -930,7 +930,7 @@ function processRequest(requestStr: string, socket: any) {
                             return sendError(
                                 socket,
                                 'chain status uncertain after inner deadline',
-                                'BROADCAST_DEADLINE'
+                                DAEMON_CODES.BROADCAST_DEADLINE
                             );
                         }
                         throw broadcastErr;

docs/EVOLUTION.md

@@ -64,6 +64,8 @@ Consolidated the market adapter with split data sources (Kibana, native API), AM
 
 **Jun 22**: Browser-safe surface enforcement completed with lazy require wrappers and storage adapter path fix. Credit runtime extended with `disallowedDealIds` filter for 1.22.x BitShares compatibility and `ratio`→`outputWeight` rename with backward-compat shim. Doc sweep across 15 files.
 
+**Jun 25**: DAEMON_ERRORS retry-path fix — `DaemonKeyStore` session-expiry retry never fired due to locally-hardcoded mismatch with canonical constants. Canonical error-code hardening — `DAEMON_CODES` added to `constants.ts` for `BROADCAST_DEADLINE`/`CREDENTIAL_DAEMON_UNAVAILABLE`, `MasterPasswordError.code` static property, replacing 12+ literal sites with single-source-of-truth references.
+
 ---
 
 ## Architecture Evolution
@@ -157,10 +159,10 @@ Removed all 89 @ts-nocheck directives, added type annotations across 67 files. R
 First stable release. Profile validation, logging overhaul, AMA delta threshold, on-chain authority resolution, credential hardening (8 finding groups), centralization of project-root/fs/math/magic-number utilities, error-path hardening, doc sweep. Post-release: headless unlock mode, Credit/MPA Claw bridge, credit runtime fixes, credential daemon hardening, test auto-discovery, settings merge consolidation, shared-account fund registry, credit/MPA collateral proportional allocation, vendored uPlot library, node config editor, analyze-git Chart.js→uPlot migration, fund registry whitelist fixes. Browser compatibility: six portable abstractions (`StorageAdapter`, `CryptoProvider`, `Config`, `PATHS`, `ProcessDiscovery`, `KeyStore`), `env.ts`, `Runtime` singleton, `path_api.ts`, pure-JS crypto fallbacks, `ecc.browser.ts`, `ecc_selector.ts`, lazy `ws`/`pm2` loading, browser bundle verification, 1288-line test suite, 15 newly browser-safe modules, 28-check dist-level verification. Credit runtime multi-asset collateral fixes and stale reborrow guard. I/O pipeline centralization through StorageAdapter. Final browser-compat gaps closed. Browser-safe enforcement, storage adapter path fix, `disallowedDealIds` filter, `outputWeight` rename, doc sweep.
 
 ### v1.0.0 → v1.0.1 (4 commits)
-Bootstrap fill pipeline refactored to use the standard same-side replacement path via `_processFillsWithBatching`, eliminating the only cross-side rotation in the codebase. AccountOrders simplified to one bot per file, removing the `{bots: {[key]: ...}}` wrapper that caused doubled-entry bugs during bot-id migration. Deferred maintenance timer guard prevents rare null/undefined spread errors during periodic blockchain fetches.
+Bootstrap fill pipeline refactored to same-side replacement, AccountOrders simplified to one bot per file, deferred maintenance timer guard.
 
-### v1.0.1 → v1.0.2 (3 changes)
-Auto-update disabled by default (`ACTIVE: true` → `false`) — explicit operator opt-in required for unattended code changes on financial systems. Update script hardened: exit code 2 → 0 on "already up to date" stops PM2 false-positive error logging, and `git stash pop` added after pull to restore previously stashed uncommitted work.
+### v1.0.1 → v1.0.2 (4 commits)
+Auto-update disabled by default, update script hardened, DAEMON_ERRORS retry-path fix, and canonical error-code hardening via `DAEMON_CODES`/`MasterPasswordError.code` static.
 
 ---
 

modules/chain_keys.ts

@@ -534,11 +534,12 @@ function verifyCurrentPassword(password, accountsData) {
 }
 
 class MasterPasswordError extends Error {
+    static code = 'MASTER_PASSWORD_FAILED';
     code: string;
     constructor(message: string) {
         super(message);
         this.name = 'MasterPasswordError';
-        this.code = 'MASTER_PASSWORD_FAILED';
+        this.code = MasterPasswordError.code;
     }
 }
 
@@ -548,7 +549,7 @@ class MasterPasswordError extends Error {
  * @returns {boolean} True if the error indicates a master password failure
  */
 function isMasterPasswordFailure(err) {
-    return !!(err && (err instanceof MasterPasswordError || err.code === 'MASTER_PASSWORD_FAILED'));
+    return !!(err && (err instanceof MasterPasswordError || err.code === MasterPasswordError.code));
 }
 
 const MASTER_PASSWORD_MAX_ATTEMPTS = CREDENTIAL_PROMPTS.MAX_MASTER_PASSWORD_ATTEMPTS;

modules/constants.ts

@@ -522,6 +522,16 @@ const DAEMON_ERRORS = Object.freeze({
     SOURCE_AUTH_DENIED: 'invalid source authentication',
 });
 
+// DAEMON_CODES: Canonical error-code constants shared between the credential
+// daemon, the bot client, and tests. Every code value is identical to its
+// property name so that a receiver comparing against e.g.
+// err.code === DAEMON_CODES.BROADCAST_DEADLINE stays in sync with
+// senders that assign the same symbol.
+const DAEMON_CODES = Object.freeze({
+    BROADCAST_DEADLINE: 'BROADCAST_DEADLINE',
+    CREDENTIAL_DAEMON_UNAVAILABLE: 'CREDENTIAL_DAEMON_UNAVAILABLE',
+});
+
 // Interactive credential-prompt limits
 // (modules/chain_keys.ts master-password authentication, etc.).
 // Capped to prevent infinite stdin loops on a corrupted vault or a forgotten
@@ -1594,4 +1604,4 @@ Object.freeze(MARKET_ADAPTER.AMAS);
 Object.freeze(MARKET_ADAPTER);
 Object.freeze(CREDENTIAL_PROMPTS);
 
-export = { ORDER_TYPES, ORDER_STATES, REBALANCE_STATES, COW_ACTIONS, DEFAULT_CONFIG, TIMING, GRID_LIMITS, LOG_LEVEL, LOGGING_CONFIG, INCREMENT_BOUNDS, FEE_PARAMETERS, CR_ZONES, DEFAULT_TARGET_CR, API_LIMITS, FILL_PROCESSING, MAINTENANCE, NODE_MANAGEMENT, PIPELINE_TIMING, UPDATER, LAUNCHER, COW_PERFORMANCE, NATIVE_CLIENT, MARKET_ADAPTER, BUILD_DIR, BTS_PRECISION, DAEMON_ERRORS, CREDENTIAL_PROMPTS };
+export = { ORDER_TYPES, ORDER_STATES, REBALANCE_STATES, COW_ACTIONS, DEFAULT_CONFIG, TIMING, GRID_LIMITS, LOG_LEVEL, LOGGING_CONFIG, INCREMENT_BOUNDS, FEE_PARAMETERS, CR_ZONES, DEFAULT_TARGET_CR, API_LIMITS, FILL_PROCESSING, MAINTENANCE, NODE_MANAGEMENT, PIPELINE_TIMING, UPDATER, LAUNCHER, COW_PERFORMANCE, NATIVE_CLIENT, MARKET_ADAPTER, BUILD_DIR, BTS_PRECISION, DAEMON_ERRORS, DAEMON_CODES, CREDENTIAL_PROMPTS };

modules/dexbot_class.ts

@@ -99,6 +99,7 @@ const {
     MAINTENANCE,
     GRID_LIMITS,
     FILL_PROCESSING,
+    DAEMON_CODES,
 } = require('./constants');
 const { PATHS, getRecalculateTriggerFile } = require('./paths');
 const { attemptResumePersistedGridByPriceMatch, decideStartupGridAction, reconcileGridOrders } = require('./order/grid_reconcile');
@@ -3336,7 +3337,7 @@ class DEXBot {
             this._suspendGridPersistenceForCredentialOutage(message);
             this.manager?.logger?.log?.(`[CREDENTIAL] ${message}. Write operations paused; re-unlock with node pm2.`, 'error');
             const wrapped: any = new Error(message);
-            wrapped.code = 'CREDENTIAL_DAEMON_UNAVAILABLE';
+            wrapped.code = DAEMON_CODES.CREDENTIAL_DAEMON_UNAVAILABLE;
             wrapped.cause = err;
             throw wrapped;
         }
@@ -3349,7 +3350,7 @@ class DEXBot {
      */
     _isCredentialDaemonError(err) {
         if (!err) return false;
-        if (err.code === 'CREDENTIAL_DAEMON_UNAVAILABLE') return true;
+        if (err.code === DAEMON_CODES.CREDENTIAL_DAEMON_UNAVAILABLE) return true;
         const message = String(err.message || '');
         return /Credential daemon|Daemon connection failed|daemon .*unavailable|dexbot-cred-daemon\.sock|ECONNREFUSED|ENOENT/.test(message);
     }

modules/dexbot_credential_client.ts

@@ -10,7 +10,7 @@ try {
 const { getStorage } = require('./storage');
 const storage = getStorage();
 const { createHmac } = require('./crypto/sync');
-const { TIMING } = require('./constants');
+const { TIMING, DAEMON_CODES } = require('./constants');
 const {
     getCredentialReadyFilePath,
     getCredentialSocketPath,
@@ -256,8 +256,8 @@ function executeOperationsViaCredentialDaemon(accountName: string, operations: a
         // the uncertainOnTimeout flag.
         if (
             isBroadcast &&
-            (errCode === 'BROADCAST_DEADLINE' ||
-                (typeof errMsg === 'string' && errMsg.startsWith('BROADCAST_DEADLINE')))
+            (errCode === DAEMON_CODES.BROADCAST_DEADLINE ||
+                (typeof errMsg === 'string' && errMsg.startsWith(DAEMON_CODES.BROADCAST_DEADLINE)))
         ) {
             throw new BroadcastUncertainError(
                 `Credential daemon broadcast uncertain: ${errCode || errMsg}`,

tests/test_chain_keys_master_password_failure.ts

@@ -6,7 +6,7 @@ console.log('Running chain_keys master password failure tests');
 const masterPasswordError = new chainKeys.MasterPasswordError('Incorrect master password after 3 attempts.');
 assert.strictEqual(chainKeys.isMasterPasswordFailure(masterPasswordError), true, 'MasterPasswordError instances should be recognized');
 assert.strictEqual(
-    chainKeys.isMasterPasswordFailure({ code: 'MASTER_PASSWORD_FAILED', message: 'Incorrect master password after 3 attempts.' }),
+    chainKeys.isMasterPasswordFailure({ code: chainKeys.MasterPasswordError.code, message: 'Incorrect master password after 3 attempts.' }),
     true,
     'plain errors carrying MASTER_PASSWORD_FAILED should be recognized'
 );

tests/test_dexbot_start_master_password_failure_output.ts

@@ -13,6 +13,9 @@ const systemPath = require.resolve('../modules/order/utils/system');
 const accountBotsPath = require.resolve('../modules/account_bots');
 const bitsharesClientPath = require.resolve('../modules/bitshares_client');
 
+// Import real MasterPasswordError before the chain_keys stub replaces it
+const { MasterPasswordError } = require('../modules/chain_keys');
+
 const originalDexbotModule = require.cache[dexbotPath];
 const originalBotSettings = require.cache[botSettingsPath];
 const originalDexbotClass = require.cache[dexbotClassPath];
@@ -74,7 +77,7 @@ function installStubs() {
 
     const masterPasswordError = new Error('Incorrect master password after 3 attempts.');
     masterPasswordError.name = 'MasterPasswordError';
-    (masterPasswordError as any).code = 'MASTER_PASSWORD_FAILED';
+    (masterPasswordError as any).code = MasterPasswordError.code;
 
     class StubSharedDEXBot {
     [key: string]: any;
@@ -101,7 +104,7 @@ function installStubs() {
         authenticate: async () => 'test-password',
         isDaemonReady: () => false,
         isDaemonResponsive: async () => false,
-        isMasterPasswordFailure: (err) => !!(err && (err.code === 'MASTER_PASSWORD_FAILED' || err.name === 'MasterPasswordError')),
+        isMasterPasswordFailure: (err) => !!(err && (err.code === MasterPasswordError.code || err.name === 'MasterPasswordError')),
     });
     setCachedModule(gracefulShutdownPath, {
         setupGracefulShutdown: () => {},

tests/test_fill_replay_guards.ts

@@ -3,7 +3,7 @@ const assert = require('assert');
 const DEXBot = require('../modules/dexbot_class');
 const chainOrders = require('../modules/chain_orders');
 const { OrderManager } = require('../modules/order');
-const { ORDER_STATES, ORDER_TYPES, TIMING } = require('../modules/constants');
+const { ORDER_STATES, ORDER_TYPES, TIMING, DAEMON_CODES } = require('../modules/constants');
 const { buildFillKey } = require('../modules/order/utils/order');
 const {
     ProcessedFillStore,
@@ -389,7 +389,7 @@ async function runTests() {
         };
         bot._executeBatchIfNeeded = async () => {
             const err = new Error('Credential daemon unavailable before COW batch broadcast: ENOENT');
-            (err as any).code = 'CREDENTIAL_DAEMON_UNAVAILABLE';
+            (err as any).code = DAEMON_CODES.CREDENTIAL_DAEMON_UNAVAILABLE;
             throw err;
         };
         bot._triggerStateRecoverySync = async () => {