|
| 1 | +// Broadcaster-gate verify test (path 3): proves the WON-BLOCK broadcast obeys |
| 2 | +// FALLBACK semantics and NEVER silent-drops. Standalone harness in the style |
| 3 | +// of tx_data_memo_test.cpp -- no btc/test CMake plumbing required. |
| 4 | +// |
| 5 | +// Build (from repo root): |
| 6 | +// g++ -std=gnu++20 -I src -I src/btclibs \ |
| 7 | +// src/impl/btc/test/block_broadcast_test.cpp -o /tmp/block_broadcast_test |
| 8 | +// Run: |
| 9 | +// /tmp/block_broadcast_test |
| 10 | +// |
| 11 | +// Maps to the integrator gate spec: |
| 12 | +// relay_p2p sink <-> btc::coin::Node::submit_block_p2p_raw -> NodeP2P:: |
| 13 | +// submit_block_raw -> message_block::make_raw (p2p_node.hpp) |
| 14 | +// submit_rpc sink <-> btc::coin::Node::submit_block_hex -> NodeRPC:: |
| 15 | +// submit_block_hex -> submitblock CallMethod (rpc.cpp:393) |
| 16 | +// |
| 17 | +// The seam (block_broadcast.hpp) is the new wiring under test; make_raw / |
| 18 | +// CallMethod themselves are already-exercised primitives. The fakes record |
| 19 | +// invocation so we can assert exactly WHICH sink fired in each scenario. |
| 20 | +// |
| 21 | +// Invariants proven: |
| 22 | +// (1) happy path (P2P up) -> P2P fires, RPC does NOT (fallback, not |
| 23 | +// always-both / no double-broadcast) |
| 24 | +// (2) degraded (P2P null/fail) -> RPC fires (fallback engages) |
| 25 | +// (3) both down -> reaches NEITHER -> won-block path screams |
| 26 | +// (4) the won-block decision (work_source.cpp) flips "reached_network" off |
| 27 | +// exactly when both sinks fail, so a found block can never be lost quietly |
| 28 | + |
| 29 | +#include <impl/btc/coin/block_broadcast.hpp> |
| 30 | + |
| 31 | +#include <cstdio> |
| 32 | + |
| 33 | +using btc::coin::broadcast_block_with_fallback; |
| 34 | + |
| 35 | +static int g_fails = 0; |
| 36 | +static void check(bool ok, const char* label) { |
| 37 | + std::printf(" %s %s\n", ok ? "PASS" : "FAIL", label); |
| 38 | + if (!ok) ++g_fails; |
| 39 | +} |
| 40 | + |
| 41 | +int main() { |
| 42 | + std::printf("== broadcaster gate: FALLBACK + never-silent-drop ==\n"); |
| 43 | + |
| 44 | + // (1) Happy path: P2P relay succeeds. RPC must NOT fire. |
| 45 | + { |
| 46 | + bool p2p_called = false, rpc_called = false; |
| 47 | + bool reached = broadcast_block_with_fallback( |
| 48 | + [&]{ p2p_called = true; return true; }, |
| 49 | + [&]{ rpc_called = true; return true; }); |
| 50 | + check(reached, "happy: block reached network"); |
| 51 | + check(p2p_called, "happy: P2P (primary) fired"); |
| 52 | + check(!rpc_called, "happy: RPC did NOT fire (no double-broadcast)"); |
| 53 | + } |
| 54 | + |
| 55 | + // (2) Degraded: P2P unavailable/failed -> RPC fallback engages. |
| 56 | + { |
| 57 | + bool p2p_called = false, rpc_called = false; |
| 58 | + bool reached = broadcast_block_with_fallback( |
| 59 | + [&]{ p2p_called = true; return false; }, // relay failed / no peer |
| 60 | + [&]{ rpc_called = true; return true; }); // bitcoind accepts |
| 61 | + check(reached, "degraded: block reached network"); |
| 62 | + check(p2p_called, "degraded: P2P attempted first"); |
| 63 | + check(rpc_called, "degraded: RPC fallback fired"); |
| 64 | + } |
| 65 | + |
| 66 | + // (2b) Degraded by null P2P sink (m_p2p == null -> empty std::function). |
| 67 | + { |
| 68 | + bool rpc_called = false; |
| 69 | + std::function<bool()> no_p2p; // empty: models m_p2p == nullptr |
| 70 | + bool reached = broadcast_block_with_fallback( |
| 71 | + no_p2p, |
| 72 | + [&]{ rpc_called = true; return true; }); |
| 73 | + check(reached, "null-p2p: block reached network"); |
| 74 | + check(rpc_called, "null-p2p: RPC fallback fired"); |
| 75 | + } |
| 76 | + |
| 77 | + // (3) Both sinks down -> reaches NEITHER -> caller MUST scream. |
| 78 | + { |
| 79 | + bool p2p_called = false, rpc_called = false; |
| 80 | + bool reached = broadcast_block_with_fallback( |
| 81 | + [&]{ p2p_called = true; return false; }, |
| 82 | + [&]{ rpc_called = true; return false; }); |
| 83 | + check(!reached, "both-down: reached NEITHER sink"); |
| 84 | + check(p2p_called, "both-down: P2P attempted"); |
| 85 | + check(rpc_called, "both-down: RPC fallback attempted"); |
| 86 | + |
| 87 | + // Mirror the won-block decision in work_source.cpp: a found block with |
| 88 | + // reached_network==false triggers the loud error (never silent-drop). |
| 89 | + bool would_scream = !reached; |
| 90 | + check(would_scream, "both-down: won-block path screams (no silent drop)"); |
| 91 | + } |
| 92 | + |
| 93 | + // (3b) No fn wired at all is handled at the work_source layer (empty both) |
| 94 | + { |
| 95 | + std::function<bool()> none; |
| 96 | + bool reached = broadcast_block_with_fallback(none, none); |
| 97 | + check(!reached, "no-sinks: reached NEITHER (work_source screams)"); |
| 98 | + } |
| 99 | + |
| 100 | + std::printf(g_fails ? "\nFAILED (%d)\n" : "\nALL PASS\n", g_fails); |
| 101 | + return g_fails ? 1 : 0; |
| 102 | +} |
0 commit comments