Fix GOT SHARE log: use p2pool format with miner address, not hex hash160

p2pool format: Received good share: diff=1.63e+02 hash=57d2030a... miner=myT1aT2PpJs9JFDKJ31og7aYb6RBesXX9D

Pass miner_address (parsed Stratum username with worker, without merged
addrs) through ShareCreationParams for human-readable log output.

Author: frstrtr

src/c2pool/c2pool_refactored.cpp

@@ -2292,24 +2292,12 @@ int main(int argc, char* argv[]) {
                         auto share_target = chain::bits_to_target(
                             p.has_frozen_fields && p.frozen_bits ? p.frozen_bits : p.bits);
                         double share_diff = chain::target_to_difficulty(share_target);
-                        // Extract primary address from username
-                        std::string miner_addr;
-                        for (const auto& [script, _] : p.merged_addresses) { (void)_; }
-                        // Use the payout script hash160 as miner identifier
-                        if (p.payout_script.size() == 25 &&
-                            p.payout_script[0] == 0x76 && p.payout_script[1] == 0xa9) {
-                            static const char* HX = "0123456789abcdef";
-                            for (int i = 3; i < 23 && i < (int)p.payout_script.size(); ++i) {
-                                miner_addr += HX[p.payout_script[i] >> 4];
-                                miner_addr += HX[p.payout_script[i] & 0xf];
-                            }
-                        }
-                        LOG_INFO << "GOT SHARE! "
+                        LOG_INFO << "Received good share: "
                                  << std::scientific << std::setprecision(2)
                                  << "diff=" << share_diff
                                  << std::defaultfloat
                                  << " hash=" << share_hash.GetHex()
-                                 << " miner=" << miner_addr;
+                                 << " miner=" << p.miner_address;
                     }
                 } catch (const std::exception& e) {
                     LOG_ERROR << "create_share_fn failed (before broadcast): " << e.what();

src/core/web_server.cpp

@@ -4372,6 +4372,21 @@ nlohmann::json MiningInterface::mining_submit(const std::string& username, const
         // unmodified — Python p2pool does NOT apply node fee to merged chains.
         if (m_create_share_fn) {
             ShareCreationParams params;
+            // Miner display name: PRIMARY_ADDR.WORKER (strip merged addrs, keep worker)
+            {
+                std::string display = username;
+                // Remove merged addresses (after first comma) but keep worker name (after last dot)
+                auto comma_pos = display.find(',');
+                std::string worker;
+                if (comma_pos != std::string::npos) {
+                    // Check for worker name after the merged addresses
+                    auto dot_pos = display.rfind('.');
+                    if (dot_pos != std::string::npos && dot_pos > comma_pos)
+                        worker = display.substr(dot_pos);
+                    display = display.substr(0, comma_pos) + worker;
+                }
+                params.miner_address = display;
+            }
 
             // Build P2PKH script from share_address (40-char hex hash160)
             if (share_address.size() == 40) {

src/core/web_server.hpp

@@ -379,6 +379,7 @@ class MiningInterface : public jsonrpccxx::JsonRpc2Server
     // Hook: called by mining_submit() pool path to create a share in the tracker.
     // All block template data needed by create_local_share() is passed through.
     struct ShareCreationParams {
+        std::string miner_address;  // Stratum username (human-readable address)
         std::vector<unsigned char> payout_script;
         std::map<uint32_t, std::vector<unsigned char>> merged_addresses;
         uint32_t block_version{0};