P2Pool-style block-found logs + fix self-banning on localhost:0

Block-found notifications now match p2pool format:
  ###  PARENT NETWORK BLOCK FOUND!  ###
  Network:    Litecoin (tLTC)
  Height:     16001
  Block hash: 05ae9008...
  Status:     ACCEPTED

  ###  MERGED BLOCK FOUND! DOGE  ###
  Chain:      DOGE (chain_id=2)
  Height:     23059
  Aux hash:   90f7bfb5...

Fix: skip banning localhost:0 (port==0) peers — these are our own
locally created shares that can fail GENTX verification during chain
growth.  This is a timing race, not a protocol error.

Author: frstrtr

src/c2pool/c2pool_refactored.cpp

@@ -1258,7 +1258,8 @@ int main(int argc, char* argv[]) {
             // When a block submission is attempted, broadcast bestblock to all P2P peers
             // and record the found block for the /recent_blocks REST endpoint.
             // stale_info: 0=accepted, 253=orphan (stale prev), 254=doa (daemon rejected)
-            web_server.set_on_block_submitted([&p2p_node, &web_server, &ioc, &node_rpc, embedded_ltc](const std::string& header_hex, int stale_info) {
+            bool is_testnet = settings->m_testnet;
+            web_server.set_on_block_submitted([&p2p_node, &web_server, &ioc, &node_rpc, embedded_ltc, is_testnet](const std::string& header_hex, int stale_info) {
                 if (header_hex.size() < 160) return;
                 // Parse the 80-byte Bitcoin wire-format block header
                 auto hb = [&](int i) -> uint8_t {
@@ -1304,13 +1305,16 @@ int main(int argc, char* argv[]) {
                     height = tmpl["height"].get<uint64_t>();
                 web_server.get_mining_interface()->record_found_block(height, block_hash);
 
-                const char* stale_str = (stale_info == 253) ? " [ORPHAN]"
-                                      : (stale_info == 254) ? " [DOA]"
+                const char* stale_str = (stale_info == 253) ? " [ORPHAN — stale prev]"
+                                      : (stale_info == 254) ? " [DOA — daemon rejected]"
                                       : "";
-                LOG_INFO << "Block found! height=" << height
-                         << " hash=" << block_hash.GetHex()
-                         << stale_str
-                         << " — broadcast bestblock to P2P peers";
+                LOG_INFO << "\n"
+                         << "  ###  PARENT NETWORK BLOCK FOUND!  ###\n"
+                         << "  Network:    Litecoin (" << (is_testnet ? "tLTC" : "LTC") << ")\n"
+                         << "  Height:     " << height << "\n"
+                         << "  Block hash: " << block_hash.GetHex() << "\n"
+                         << "  Status:     " << (stale_info == 0 ? "ACCEPTED" : stale_str) << "\n"
+                         << "  Broadcast:  bestblock sent to P2P peers";
 
                 // Schedule post-submission orphan check at +30s and +120s (RPC mode only)
                 if (stale_info == 0 && !embedded_ltc)

src/c2pool/merged/merged_mining.cpp

@@ -426,7 +426,7 @@ bool AuxChainRPC::submit_aux_block(const uint256& block_hash, const std::string&
 {
     try {
         call("submitauxblock", nlohmann::json::array({block_hash.GetHex(), auxpow_hex}));
-        LOG_INFO << "[MM:" << m_config.symbol << "] Aux block submitted successfully!";
+        LOG_INFO << "[MM:" << m_config.symbol << "] Aux block ACCEPTED by daemon!";
         return true;
     } catch (const std::exception& e) {
         LOG_WARNING << "[MM:" << m_config.symbol << "] submitauxblock failed: " << e.what();
@@ -662,7 +662,13 @@ void MergedMiningManager::try_submit_merged_blocks(
             continue;  // doesn't meet this chain's target
         }
 
-        LOG_INFO << "[MM:" << chain.config.symbol << "] Parent PoW meets aux target! Submitting merged block...";
+        LOG_INFO << "\n"
+                 << "  ###  MERGED BLOCK FOUND! " << chain.config.symbol << "  ###\n"
+                 << "  Chain:      " << chain.config.symbol << " (chain_id=" << chain.config.chain_id << ")\n"
+                 << "  Height:     " << chain.current_work.height << "\n"
+                 << "  Aux hash:   " << chain.current_work.block_hash.GetHex().substr(0, 32) << "...\n"
+                 << "  Aux target: " << chain.current_work.target.GetHex().substr(0, 32) << "...\n"
+                 << "  Parent PoW: " << parent_hash.GetHex().substr(0, 32) << "...";
 
         // Build aux merkle proof for this chain's slot
         auto proof = m_tree.compute_root(slot_hashes, slot);

src/impl/ltc/node.cpp

@@ -717,9 +717,13 @@ void NodeImpl::run_think()
                     trim_chain(m_tracker.verified, "verified", /*owns_data=*/false);
                     trim_chain(m_tracker.chain, "chain");
 
-                    // Ban peers that provided invalid/unverifiable shares
+                    // Ban peers that provided invalid/unverifiable shares.
+                    // Skip localhost:0 — that's our own locally created shares
+                    // which can fail GENTX during chain growth (timing race, not a bug).
                     auto now = std::chrono::steady_clock::now();
                     for (const auto& bad_addr : result.bad_peer_addresses) {
+                        if (bad_addr.port() == 0)
+                            continue; // local share — don't ban ourselves
                         LOG_WARNING << "run_think: banning peer " << bad_addr.to_string()
                                     << " for unverifiable shares";
                         m_ban_list[bad_addr] = now + m_ban_duration;