Merge pull request #234 from frstrtr/ltc-doge/ltc-minproto-split-resoak

ltc: split advertised protocol version from accept-floor (3600/3301)

Author: frstrtr

src/core/coin_params.hpp

@@ -61,6 +61,7 @@ struct CoinParams
     uint32_t target_lookbehind = 0;          // shares to look back for target calc
     uint32_t spread = 0;                     // PPLNS spread multiplier
     uint32_t minimum_protocol_version = 0;   // min p2pool protocol version
+    uint32_t advertised_protocol_version = 0; // version we ADVERTISE (our capability); >= floor, separate from accept-floor per p2pool
     uint32_t block_max_size = 0;
     uint32_t block_max_weight = 0;
 

src/impl/ltc/node.cpp

@@ -247,7 +247,7 @@ int NodeImpl::get_verified_count() const { return get_tracker_snapshot().verifie
 void NodeImpl::send_version(peer_ptr peer)
 {
     auto rmsg = ltc::message_version::make_raw(
-        m_tracker.m_params->minimum_protocol_version,
+        m_tracker.m_params->advertised_protocol_version,  // advertise our V36 capability, NOT the accept-floor (handle_version:328 keeps floor)
         1,                                    // services
         addr_t{1, peer->addr()},              // addr_to (the remote)
         addr_t{1, NetService{"0.0.0.0", m_tracker.m_params->p2p_port}}, // addr_from (us)

src/impl/ltc/params.hpp

@@ -62,6 +62,7 @@ inline core::CoinParams make_coin_params(bool testnet)
     p.target_lookbehind        = 200;
     p.spread                   = 3;
     p.minimum_protocol_version = 3301;  // accept v35 (3502) peers for v35->v36 AutoRatchet crossing
+    p.advertised_protocol_version = 3600;  // advertise V36 capability; >= .82 latched min (3503) so crossing peers accept us
     p.block_max_size           = 1000000;
     p.block_max_weight         = 4000000;