Skip to content

Commit cff33ca

Browse files
authored
ci(build): do not cancel-in-progress on push runs (#637)
The concurrency group is per-ref (github.workflow-github.ref). On master, every merge is a push to the same ref, so back-to-back merges share one group and cancel-in-progress kills the prior merge in-flight rollup before it verifies green. #626 (concurrency-groups) bit the #617 web-static lane exactly this way: the last completed master CI run (28692641464) shows Web-static verify=cancelled while Windows x86_64=success. Gate cancel-in-progress to non-push events only. PR churn (rapid re-pushes to a PR ref) still de-dupes and sheds the shared-pool OOM load that #626 targeted; master/release/tag runs always run to completion so a merged SHA is actually verified. Fenced to the concurrency block, no job changes. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
1 parent a37b58f commit cff33ca

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

.github/workflows/build.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ on:
1313
# distinct PRs/branches never cancel each other.
1414
concurrency:
1515
group: ${{ github.workflow }}-${{ github.ref }}
16-
cancel-in-progress: true
16+
# Only cancel superseded PR runs; NEVER cancel a push (master/release/tag)
17+
# run - back-to-back merges to master share this ref-group, so cancel-on-push
18+
# would kill a merged SHA in-flight rollup before it verifies green (#626
19+
# bit the #617 web-static lane exactly this way). PR churn still de-dupes.
20+
cancel-in-progress: ${{ github.event_name != 'push' }}
1721

1822

1923
jobs:

0 commit comments

Comments
 (0)