web(d-web): getstats stale/DOA from live sharechain hook, not empty m_node stub (#462)

getstats() seeded orphan/doa/stale_shares from m_node->get_stale_stats(),
but m_node is the empty stub on prod (same root cause as the founding
0-stub bug). Result: the pool_statistics block reported orphan=doa=stale=0
while /stale_rates -- which already reads the real m_sharechain_stats_fn --
told the truth. Prefer that same live hook here (orphan/dead/total ->
orphan_count/doa_count/stale_count/stale_prop), m_node only as fallback.

Charter: a dashboard must never lie about prod health.

Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>

Author: frstrtr

src/core/web_server.cpp

@@ -2946,9 +2946,24 @@ nlohmann::json MiningInterface::getstats(const std::string& request_id)
             block_height = m_cached_template["height"].get<uint64_t>();
     }
 
+    // Prefer the live sharechain-stats hook over the empty m_node stub: m_node
+    // returns zeros on prod, so getstats lied about orphan/DOA/stale shares while
+    // /stale_rates (same hook) reported the truth. Charter: dashboards must not lie.
     nlohmann::json stale = {{"orphan_count", 0}, {"doa_count", 0}, {"stale_count", 0}, {"stale_prop", 0.0}};
-    if (m_node)
+    if (m_sharechain_stats_fn) {
+        auto sc = m_sharechain_stats_fn();
+        uint64_t total  = sc.value("total_shares", uint64_t(0));
+        uint64_t orphan = sc.value("orphan_shares", uint64_t(0));
+        uint64_t dead   = sc.value("dead_shares", uint64_t(0));
+        stale["orphan_count"] = orphan;
+        stale["doa_count"]    = dead;
+        stale["stale_count"]  = orphan + dead;
+        stale["stale_prop"]   = total > 0
+            ? static_cast<double>(orphan + dead) / static_cast<double>(total)
+            : 0.0;
+    } else if (m_node) {
         stale = m_node->get_stale_stats();
+    }
 
     nlohmann::json protocol_messages = nlohmann::json::array();
     if (m_protocol_messages_fn) {