Merge pull request #386 from frstrtr/dashboard/pplns-parse-finite-total

web(pplns): clamp totalPrimary so overflowing finite-amount sums stay finite

Author: frstrtr

web-static/sharechain-explorer/dist/pplns-view.js

@@ -1,6 +1,6 @@
 {
   "version": "0.1.0-alpha",
-  "generated": "2026-04-20T11:31:29.618Z",
+  "generated": "2026-06-23T20:03:41.175Z",
   "files": [
     "pplns-view.js",
     "sharechain-explorer.js",
@@ -12,19 +12,19 @@
     "shared-core.js.map"
   ],
   "integrity": {
-    "pplns-view.js": "sha384-0VM4qQvoTorQ+CIVNmSffMMclp0lC+s8gufF8cTgGc0rSKrwRxhovNEjD9tCT1E6",
-    "pplns-view.js.map": "sha384-+HmQQn0hfXMRrFXthc3U59CKNKB+cECK9YuUySdhFqfG+feAMeSk/CABTqFkOZoG",
-    "sharechain-explorer.js": "sha384-NSA2iUIBBicV40Ui5pj0YE0yuSsh2AZexj92FvpdEqxSs/3m832k8Xmy9abGgWJF",
-    "sharechain-explorer.js.map": "sha384-8gKhY+rVZ5SYmZNZ8q7hhsnU9sAabkGehUWcdoLK2ygS4Iwt/AoLj4gYulGNsYuv",
-    "shared-core.js": "sha384-fLK/ciO7Ip2VNtUazZBKnenRgTfVKRjVYUCGQCnZgovE6Y/l+jpxBZkziKl21EBw",
-    "shared-core.js.map": "sha384-cNe7eMGecoXitiz9msnxaJ9mEZUWLhnGDyhpk9Xe4UOjKZ909m17gYWKJo6yTEwT"
+    "pplns-view.js": "sha384-6e2Mhmz6cUZqdwrPYB2ZRKlz0cOd/iTvibG6aY7N0WK3em99c69vwabsaRw0k4RZ",
+    "pplns-view.js.map": "sha384-cOkK3Ps9z0WoqfND7NTmANSnCOXCSam3sPjMgdlg8wCXXV2waXlGMvSN3vJlvK4p",
+    "sharechain-explorer.js": "sha384-36U2+DJ4qtenJNwOd9HDd+PoLyraP5y4BIZyV/y+VwfA0/K04hUv9ybHhSf2904n",
+    "sharechain-explorer.js.map": "sha384-TvmBt1Ekl48fkyPOBTmt3uxeO3LRAJUH2ppSStqFRu/tc/zLncnMPdVnBMAxl9mj",
+    "shared-core.js": "sha384-shFs3b7dkb/ooHhtaqwIZwSuYwFwk9VonRrrBg8nUSyS7Sqfbc1PDX5+ufap/Wvz",
+    "shared-core.js.map": "sha384-A1CSDMTBmnHbS8vHRdtNIHb8kZN2GTgdWz/aTce3xNY6eAmWiTW0yN8hCpign5gM"
   },
   "sizes": {
-    "pplns-view.js": 31019,
-    "pplns-view.js.map": 117518,
-    "sharechain-explorer.js": 58175,
-    "sharechain-explorer.js.map": 273462,
-    "shared-core.js": 25700,
-    "shared-core.js.map": 113705
+    "pplns-view.js": 31660,
+    "pplns-view.js.map": 122139,
+    "sharechain-explorer.js": 58166,
+    "sharechain-explorer.js.map": 273452,
+    "shared-core.js": 25691,
+    "shared-core.js.map": 113695
   }
 }

web-static/sharechain-explorer/dist/pplns-view.js.map

@@ -49,6 +49,15 @@ function num(v: unknown, fallback = 0): number {
   return typeof v === 'number' && Number.isFinite(v) ? v : fallback;
 }
 
+// A sum of individually-finite per-miner amounts can still overflow to
+// +/-Infinity when values approach Number.MAX_VALUE (each passes the
+// amount>0 guard, but their aggregate does not). Clamp so totalPrimary
+// stays finite at the server->client trust boundary. Regression:
+// tests/unit/pplns-parse-properties.test.ts overflow case (seed 1831858192).
+function finiteTotal(sum: number): number {
+  return Number.isFinite(sum) ? sum : Number.MAX_VALUE;
+}
+
 function str(v: unknown): string | undefined {
   return typeof v === 'string' && v.length > 0 ? v : undefined;
 }
@@ -119,7 +128,7 @@ function parseNewShape(obj: Record<string, unknown>): PplnsSnapshot {
   const snap: PplnsSnapshot = {
     totalPrimary: totalPrimary > 0
       ? totalPrimary
-      : miners.reduce((s, m) => s + m.amount, 0),
+      : finiteTotal(miners.reduce((s, m) => s + m.amount, 0)),
     mergedChains,
     mergedTotals,
     schemaVersion: str(obj.schema_version) ?? '1.0',
@@ -258,7 +267,7 @@ function parseLegacyShape(obj: Record<string, unknown>): PplnsSnapshot {
     entries.push({ address: addr, amount, merged });
   }
 
-  const totalPrimary = entries.reduce((s, e) => s + e.amount, 0);
+  const totalPrimary = finiteTotal(entries.reduce((s, e) => s + e.amount, 0));
   entries.sort((a, b) => b.amount - a.amount);
 
   const miners: PplnsMiner[] = entries.map((e) => ({

web-static/sharechain-explorer/dist/sharechain-explorer.js

@@ -300,6 +300,30 @@ test('parseSnapshot: non-finite amounts are dropped, total stays finite', () =>
   }
 });
 
+test('parseSnapshot: finite amounts whose SUM overflows stay finite', () => {
+  // Each amount is finite and passes the amount>0 guard, but the
+  // aggregate overflows to +Infinity. totalPrimary must be clamped
+  // finite (finiteTotal). Shrunk counterexample: seed 1831858192,
+  // raw = [8.98e292, 1.797e308] (legacy bare-number / array path).
+  const big = 1.797693134862315e+308; // just under Number.MAX_VALUE
+  for (const raw of [
+    [8.98128139290624e+292, big],                 // legacy array path
+    { a: big, b: big },                            // legacy dict path
+    { total_primary: 0,                            // new-shape fallback sum
+      miners: [{ address: 'a', amount: big, pct: 0 },
+               { address: 'b', amount: big, pct: 0 }] },
+  ]) {
+    const snap = parseSnapshot(raw);
+    assert.ok(Number.isFinite(snap.totalPrimary),
+      `totalPrimary overflowed for ${JSON.stringify(raw).slice(0, 40)}`);
+    // Per-miner pct must remain a finite number in [0,1].
+    for (const m of snap.miners) {
+      assert.ok(Number.isFinite(m.pct));
+      assert.ok(m.pct >= 0 && m.pct <= 1.0000001);
+    }
+  }
+});
+
 test('parseSnapshot: non-finite legacy-object amounts are dropped', () => {
   // Legacy { addr: { amount } } shape with a non-finite amount field.
   for (const bad of [Infinity, -Infinity, NaN]) {