Merge pull request #810 from frstrtr/dash/embedded-superblock-govsync

dash(embedded): daemonless superblock payee sourcing via govsync (governance triggers)

Author: frstrtr

.github/workflows/build.yml

@@ -144,7 +144,7 @@ jobs:
                     core_test sharechain_test share_test btc_share_test \
                     test_threading test_weights \
                     test_header_chain test_mempool test_template_builder \
-                    test_doge_chain test_compact_blocks test_dash_x11_kat test_dash_header_chain test_dash_block_replay test_dash_conformance test_dash_subsidy test_dash_mempool test_dash_simplifiedmns test_dash_quorum test_dash_quorum_root test_dash_mn_state test_dash_embedded_gbt test_dash_underfill_guard test_dash_smldiff test_dash_p2p_messages test_dash_p2p_connection test_dash_p2p_node test_dash_node_interface test_dash_config test_dash_broadcaster test_dash_broadcaster_full test_dash_share_hash_link test_dash_block_relay test_dash_rpc_request test_dash_rpc_conf test_dash_block_producer test_dash_embedded_relay_e2e test_dash_block_relay_plan test_dash_version_activation_latch test_dash_block_relay_binding test_dash_block_relay_dual_arm test_dash_coinbase_parity test_dash_coinbase_muldiv test_dash_donation_combined test_dash_g3_assembled test_dash_work_target test_dash_work_job_targets test_dash_stratum_binding test_dash_job_notify_roundtrip test_dash_cb_payee test_dash_stratum_notify_roundtrip test_dash_poolnode_messages test_dash_peer test_dash_share_tracker test_dash_node test_dash_share_messages test_dash_stratum_extranonce_split test_dash_stratum_submit_reassembly test_dash_difficulty_parity test_dash_auto_ratchet test_dash_min_protocol_gate test_dash_work_source test_dash_node_coin_state test_dash_coin_state_maintainer test_dash_node_embedded_wire test_dash_node_reception_wire test_dash_get_work test_dash_stratum_work_source \
+                    test_doge_chain test_compact_blocks test_dash_x11_kat test_dash_header_chain test_dash_block_replay test_dash_conformance test_dash_subsidy test_dash_mempool test_dash_simplifiedmns test_dash_quorum test_dash_quorum_root test_dash_mn_state test_dash_embedded_gbt test_dash_underfill_guard test_dash_smldiff test_dash_p2p_messages test_dash_p2p_connection test_dash_p2p_node test_dash_node_interface test_dash_config test_dash_broadcaster test_dash_broadcaster_full test_dash_share_hash_link test_dash_block_relay test_dash_rpc_request test_dash_rpc_conf test_dash_block_producer test_dash_embedded_relay_e2e test_dash_block_relay_plan test_dash_version_activation_latch test_dash_block_relay_binding test_dash_block_relay_dual_arm test_dash_coinbase_parity test_dash_coinbase_muldiv test_dash_donation_combined test_dash_g3_assembled test_dash_work_target test_dash_work_job_targets test_dash_stratum_binding test_dash_job_notify_roundtrip test_dash_cb_payee test_dash_stratum_notify_roundtrip test_dash_poolnode_messages test_dash_peer test_dash_share_tracker test_dash_node test_dash_share_messages test_dash_stratum_extranonce_split test_dash_stratum_submit_reassembly test_dash_difficulty_parity test_dash_auto_ratchet test_dash_min_protocol_gate test_dash_work_source test_dash_node_coin_state test_dash_coin_state_maintainer test_dash_node_embedded_wire test_dash_node_reception_wire test_dash_get_work test_dash_stratum_work_source test_dash_superblock \
                     test_multiaddress_pplns test_pplns_stress \
                     test_hash_link test_decay_pplns \
                     test_pplns_consensus \
@@ -332,7 +332,7 @@ jobs:
                     test_threading test_weights \
                     test_header_chain test_mempool test_template_builder \
                     test_doge_chain test_compact_blocks test_dash_x11_kat \
-                    test_dash_header_chain test_dash_block_replay test_dash_conformance test_dash_subsidy test_dash_mempool test_dash_simplifiedmns test_dash_quorum test_dash_quorum_root test_dash_mn_state test_dash_embedded_gbt test_dash_underfill_guard test_dash_smldiff test_dash_p2p_messages test_dash_p2p_connection test_dash_p2p_node test_dash_node_interface test_dash_config test_dash_broadcaster test_dash_broadcaster_full test_dash_share_hash_link test_dash_block_relay test_dash_rpc_request test_dash_rpc_conf test_dash_block_producer test_dash_embedded_relay_e2e test_dash_block_relay_plan test_dash_version_activation_latch test_dash_block_relay_binding test_dash_block_relay_dual_arm test_dash_coinbase_parity test_dash_coinbase_muldiv test_dash_donation_combined test_dash_g3_assembled test_dash_work_target test_dash_work_job_targets test_dash_stratum_binding test_dash_job_notify_roundtrip test_dash_cb_payee test_dash_stratum_notify_roundtrip test_dash_poolnode_messages test_dash_peer test_dash_share_tracker test_dash_node test_dash_share_messages test_dash_stratum_extranonce_split test_dash_stratum_submit_reassembly test_dash_difficulty_parity test_dash_auto_ratchet test_dash_min_protocol_gate test_dash_work_source test_dash_node_coin_state test_dash_coin_state_maintainer test_dash_node_embedded_wire test_dash_node_reception_wire test_dash_get_work test_dash_stratum_work_source \
+                    test_dash_header_chain test_dash_block_replay test_dash_conformance test_dash_subsidy test_dash_mempool test_dash_simplifiedmns test_dash_quorum test_dash_quorum_root test_dash_mn_state test_dash_embedded_gbt test_dash_underfill_guard test_dash_smldiff test_dash_p2p_messages test_dash_p2p_connection test_dash_p2p_node test_dash_node_interface test_dash_config test_dash_broadcaster test_dash_broadcaster_full test_dash_share_hash_link test_dash_block_relay test_dash_rpc_request test_dash_rpc_conf test_dash_block_producer test_dash_embedded_relay_e2e test_dash_block_relay_plan test_dash_version_activation_latch test_dash_block_relay_binding test_dash_block_relay_dual_arm test_dash_coinbase_parity test_dash_coinbase_muldiv test_dash_donation_combined test_dash_g3_assembled test_dash_work_target test_dash_work_job_targets test_dash_stratum_binding test_dash_job_notify_roundtrip test_dash_cb_payee test_dash_stratum_notify_roundtrip test_dash_poolnode_messages test_dash_peer test_dash_share_tracker test_dash_node test_dash_share_messages test_dash_stratum_extranonce_split test_dash_stratum_submit_reassembly test_dash_difficulty_parity test_dash_auto_ratchet test_dash_min_protocol_gate test_dash_work_source test_dash_node_coin_state test_dash_coin_state_maintainer test_dash_node_embedded_wire test_dash_node_reception_wire test_dash_get_work test_dash_stratum_work_source test_dash_superblock \
                     test_hash_link test_decay_pplns \
                     test_pplns_consensus \
                     test_v36_script_sorting test_v36_cross_impl_refhash \

src/c2pool/main_dash.cpp

@@ -75,6 +75,8 @@
 #include <impl/dash/coin/tip_ingest.hpp>         // wire_tip_ingest (leg 2)
 #include <impl/dash/coin/block_connect_ingest.hpp>   // wire_block_connect_ingest (leg 3)
 #include <impl/dash/coin/mn_list_ingest.hpp>     // wire_mn_list_ingest (leg 4)
+#include <impl/dash/coin/govsync_ingest.hpp>     // wire_govobject_ingest / wire_govvote_ingest (E-SUPERBLOCK)
+#include <impl/dash/coin/superblock.hpp>         // get_superblock_payments / superblock_budget (E-SUPERBLOCK)
 #include <impl/dash/coin/mn_seed.hpp>            // E2c: RPC protx-list MN-set seed (parse_protx_list_seed)
 #include <impl/dash/node.hpp>          // dash::Node — sharechain pool-node (NodeBridge<NodeImpl,Legacy,Actual>)
 #include <impl/dash/config.hpp>        // dash::Config (PoolConfig/CoinConfig)
@@ -436,7 +438,8 @@ int run_node(bool testnet, const std::string& rpc_endpoint,
              const std::string& external_ip,
              const std::string& coin_p2p_magic_hex,
              bool force_won_block,
-             const std::string& operator_message_blob_hex)
+             const std::string& operator_message_blob_hex,
+             bool embedded_superblock)
 {
     namespace io = boost::asio;
 
@@ -2202,6 +2205,17 @@ int run_node(bool testnet, const std::string& rpc_endpoint,
         coin_feed_subs.push_back(
             c2pool::dash::wire_mnlistdiff_ingest(coin_state, *maintainer));
 
+        // Legs 6-7 (E-SUPERBLOCK — DAEMONLESS SUPERBLOCK PAYEE SOURCING): the
+        // governance-object + vote feed off the coin-P2P govsync leg. govobj
+        // triggers advance the GovernanceStore (winning-trigger schedule);
+        // govobjvote funding votes feed the tally (counted only when verified —
+        // see the vote-verifier seam below). This is what lets the embedded arm
+        // serve a SUPERBLOCK height daemonlessly instead of falling back.
+        coin_feed_subs.push_back(
+            c2pool::dash::wire_govobject_ingest(coin_state, *maintainer));
+        coin_feed_subs.push_back(
+            c2pool::dash::wire_govvote_ingest(coin_state, *maintainer));
+
         // getmnlistd base tracker: the block hash the local SML is current at.
         // Cold start = ZERO (full snapshot). Each accepted mnlistdiff advances
         // it to diff.blockHash so the NEXT request is an incremental diff off
@@ -2356,6 +2370,78 @@ int run_node(bool testnet, const std::string& rpc_endpoint,
                 [sb_cycle](uint32_t next_height) {
                     return dash::coin::is_superblock_height(next_height, sb_cycle);
                 });
+
+            // E-SUPERBLOCK: daemonless superblock payee provider. At a superblock
+            // height the provider resolves the winning governance trigger's
+            // budget-valid (script, amount) schedule from the GovernanceStore the
+            // govsync legs (6-7) feed, so the embedded arm can serve the correct
+            // superblock coinbase WITHOUT dashd. superblock_schedule() returns
+            // nullopt when there is no trigger-confident winner (unfunded OR
+            // under-synced OR over-budget OR the R6 desync latch fired) — the
+            // NodeCoinState guard then FAILS CLOSED to the reward-safe dashd
+            // fallback (never guesses payees).
+            //
+            // Enabled ONLY under --embedded-superblock (opt-in, default OFF). With
+            // it OFF, set_require_superblock_provider(false) preserves the prior
+            // reward-safe behaviour EXACTLY (every superblock height falls back).
+            //
+            // FAIL-CLOSED BY CONSTRUCTION until vote-verify lands, TRIPLY:
+            //   1. the funding tally counts only votes the maintainer's
+            //      vote-verifier accepts — and that verifier is UNSET here.
+            //      (Follow-up contract: BLS by the voting MN's OPERATOR key
+            //      over govvote_signature_hash — dashcore verifies TRIGGER
+            //      funding votes against pubKeyOperator, NOT the
+            //      ECDSA/keyIDVoting path, which is proposal-only. See
+            //      CoinStateMaintainer::set_vote_verifier.)
+            //   2. the weighted tally needs the vote-weight/membership seam
+            //      (GovernanceStore::set_vote_weight_fn) — also UNSET here
+            //      (the DIP-4 SML lacks collateral outpoints; needs the full
+            //      DMN view).
+            //   3. the R5 govsync-completeness gate
+            //      (set_superblock_sync_complete_fn) is NOT wired — the
+            //      NodeCoinState guard refuses the serve path structurally,
+            //      so landing vote-verify alone can never open it.
+            // The parse/selection/template-emit logic is proven by the KATs;
+            // flipping this fully live is gated on vote-verify + completeness
+            // + a funded-superblock soak.
+            {
+                const int64_t budget_cycle = sb_cycle;
+                // Chain-strict trigger parsing + dashcore threshold inputs:
+                // min-quorum is chainparams nGovernanceMinQuorum; the
+                // threshold itself re-derives from the weighted SML count on
+                // every accepted mnlistdiff (maintainer reseed — dashcore
+                // nAbsVoteReq = max(minQuorum, weighted/10)). Cross-checkable
+                // against dashd getgovernanceinfo.fundingthreshold.
+                maintainer->set_gov_params(
+                    testnet, testnet ? dash::coin::DASH_GOV_MIN_QUORUM_TESTNET
+                                     : dash::coin::DASH_GOV_MIN_QUORUM_MAINNET);
+                // Superblock ctx for the R6 coinbase cross-check + executed-
+                // cycle pruning on the block-connect leg.
+                maintainer->set_superblock_ctx(
+                    [sb_cycle](uint32_t h) {
+                        return dash::coin::is_superblock_height(h, sb_cycle);
+                    },
+                    [budget_cycle](uint32_t h) {
+                        return dash::coin::superblock_budget(
+                            h, static_cast<int>(budget_cycle));
+                    });
+                node_coin_state.set_superblock_provider(
+                    [maint = maintainer.get()](uint32_t next_height)
+                        -> std::optional<std::vector<dash::coin::SuperblockPayment>> {
+                        return maint->superblock_schedule(next_height);
+                    });
+                node_coin_state.set_require_superblock_provider(embedded_superblock);
+                // NOTE deliberately NOT set: set_superblock_sync_complete_fn
+                // (R5). Until a govsync-completeness proof exists, superblock
+                // heights refuse the embedded arm even with the flag on.
+                if (embedded_superblock)
+                    LOG_INFO << "[E-SUPERBLOCK] daemonless superblock arm ENABLED "
+                                "(--embedded-superblock); superblock heights served "
+                                "from govsync triggers when trigger-confident, else "
+                                "fail closed to dashd. Vote-verify (BLS operator) + "
+                                "completeness gate pending => currently fails "
+                                "closed until pinned.";
+            }
         }
 
         // E4 re-soak fix (constant −66,966,830-duff creditPool bias): the
@@ -2767,6 +2853,18 @@ int run_node(bool testnet, const std::string& rpc_endpoint,
                 auto tip_entry = hc->tip();
                 const uint256 tip = tip_entry ? tip_entry->hash : uint256::ZERO;
                 cp->send_getmnlistd(*sml_base, tip);
+                // E-SUPERBLOCK: prime the governance object/vote sync (triggers
+                // + funding votes) so a superblock height can be served
+                // daemonlessly. Zero nProp + empty filter => request all.
+                // Handshake-only today — there is NO tip-change re-prime yet.
+                // KNOWN GAP (pre-enable requirement): dashcore answers govsync
+                // with INVENTORY (MSG_GOVERNANCE_OBJECT/_VOTE invs), not
+                // direct govobj/govobjvote messages, and our inv handler does
+                // not getdata governance types — so this leg is currently
+                // INERT (an extra fail-closed layer: the store stays empty).
+                // The inv-driven getdata + per-object vote sync + periodic
+                // re-prime co-land with vote-verify before any enable.
+                cp->send_govsync();
             });
 
         std::cout << "[run] E2a live-feed wired: header-chain(" << hdr_db
@@ -3430,6 +3528,7 @@ int main(int argc, char** argv)
     bool embedded_mainnet = false;             // --embedded-mainnet: gate-lift, allow the daemonless embedded template arm on MAINNET (byte-parity proven; default OFF = dashd fallback)
     std::string coin_p2p_magic = "";           // --coin-p2p-magic HEX: override the embedded CoinClient wire magic (e.g. regtest fcc1b7dc); default mainnet/testnet
     bool force_won_block = false;              // --regtest-force-won-block: fail-closed regtest E5 harness (drive one real won block through the run-path dual-path)
+    bool embedded_superblock = false;          // --embedded-superblock: OPT-IN daemonless superblock payee sourcing via govsync (E-SUPERBLOCK); default OFF = superblock heights fall back to dashd (reward-safe)
     std::string stratum_host = "0.0.0.0";      // --stratum [HOST:]PORT bind interface (default all)
     uint16_t    stratum_port = 0;              // 0 disables the Stratum accept-loop; --stratum sets it
     bool embedded_utxo = false;                // --embedded-utxo: arm the E2b UTXO/fee lane (opt-in)
@@ -3500,6 +3599,8 @@ int main(int argc, char** argv)
             coin_p2p_magic = argv[++i];
         else if (std::strcmp(argv[i], "--regtest-force-won-block") == 0)
             force_won_block = true;
+        else if (std::strcmp(argv[i], "--embedded-superblock") == 0)
+            embedded_superblock = true;
         else if (std::strcmp(argv[i], "--embedded-utxo") == 0)
             embedded_utxo = true;
         else if ((std::strcmp(argv[i], "--give-author") == 0 ||
@@ -3620,7 +3721,7 @@ int main(int argc, char** argv)
                         coin_zmq_hashblock,
                         external_ip,
                         coin_p2p_magic, force_won_block,
-                        operator_message_blob_hex);
+                        operator_message_blob_hex, embedded_superblock);
     }
     return run_selftest();
 }

src/core/address_utils.cpp

@@ -116,9 +116,24 @@ std::string address_to_hash160(const std::string& address, std::string& addr_typ
                 carry >>= 8;
             }
         }
+        // P2SH version-byte whitelist. Chain-agnostic: an address whose
+        // version byte is a known P2SH prefix of ANY supported coin yields a
+        // P2SH script; everything else falls through to P2PKH. This is safe
+        // only while no supported coin uses one of these bytes as its P2PKH
+        // version — verified against upstream chainparams:
+        //   0x05 BTC/BCH-legacy mainnet P2SH ('3')
+        //   0x32 LTC mainnet P2SH ('M')          0x3a LTC testnet P2SH ('Q')
+        //   0x16 DOGE mainnet P2SH ('9'/'A')
+        //   0xc4 BTC/LTC/DOGE/DGB testnet P2SH ('2')
+        //   0x10 DASH mainnet P2SH ('7')         0x13 DASH testnet P2SH ('8'/'9')
+        // P2PKH versions in use (must never appear above): 0x00 BTC, 0x30 LTC,
+        // 0x1e DOGE/DGB, 0x4c DASH, 0x8c DASH-testnet, 0x6f BTC/LTC-testnet.
+        // (DASH bytes verified against dashpay/dash chainparams.cpp: mainnet
+        // SCRIPT_ADDRESS=16, testnet/devnet/regtest SCRIPT_ADDRESS=19.)
         uint8_t version = decoded[0];
         if (version == 0x32 || version == 0x05 || version == 0x3a ||
-            version == 0xc4 || version == 0x16) {
+            version == 0xc4 || version == 0x16 || version == 0x10 ||
+            version == 0x13) {
             addr_type = "p2sh";
         } else {
             addr_type = "p2pkh";