ltc: lower minimum_protocol_version floor 3600->3301 (admit v35 for crossing) - #111
Merged
Conversation
The live LTC peer-admission gate is params.hpp:64 (CoinParams.minimum_protocol_version), read at ltc/node.cpp:307. It was hardcoded to 3600 (== ADVERTISED v36), which rejects every v35 (3502) peer at handshake. A 3600 floor defeats the v35->v36 transition by construction: AutoRatchet needs a mixed v35/v36 population to ratchet against. This completes 0f99754, which lowered the vestigial config_pool.hpp:37 constant to 3301 but missed the runtime struct in params.hpp that ltc/node.cpp actually gates on. Conformance fix, not a posture change (the constant comment already says accept v35). Runtime-behavior-preserving for v36<->v36 (both prod peers advertise 3600 >= 3301). LTC tree only; DOGE rides this same LTC sharechain (no separate doge pool floor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/impl/ltc/params.hpp:64:p.minimum_protocol_version3600->3301. LTC tree only. One file.Why
The live LTC peer-admission gate is
CoinParams.minimum_protocol_version(params.hpp:64), read atltc/node.cpp:307. Hardcoded3600(== our ADVERTISED v36) rejects every v35 (3502) peer at handshake. A 3600 hard floor defeats the v35->v36 transition by construction: AutoRatchet needs a mixed v35/v36 population to ratchet against, and the constant comment itself says "accept v35".Completes 0f99754, which lowered the vestigial
config_pool.hpp:37constant to 3301 but missed the runtime struct thatltc/node.cppactually gates on. (Confirmed:ltc/node.cpp:307readsm_params->minimum_protocol_version; thePoolConfigconstant is NOT consulted on the LTC path.) Conformance, not a posture change.Routing / scope notes (per integrator constraints)
src/impl/ltc/. No DOGE/DGB/BTC trees.src/impl/doge/pool floor —src/impl/doge/contains onlycoin/(the merged-mining coin def). DOGE rides this same LTC sharechain, so this PR covers the LTC+DOGE crossing. The 3600 floor atsrc/impl/dgb/config_pool.hpp:34belongs to DigiByte (DGB), a separate coin/sharechain (and DGB gates via thePoolConfigconstant, not params) — handled as a separate decision, not bundled here.Gating
Per-coin LTC smoke. HOLD merge for operator approval (standing rule).