Skip to content

btc(donation): forrestv P2PK on v36 gentx, not LTC P2SH (FLAG6) [cut-only, do-not-merge] #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frstrtr wants to merge 1 commit into from
Closed

btc(donation): forrestv P2PK on v36 gentx, not LTC P2SH (FLAG6) [cut-only, do-not-merge] #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/impl/btc/config_pool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,14 @@ class PoolConfig : protected core::Fileconfig
0x87 // OP_EQUAL
};

// Returns the correct donation script based on share version.
// Pre-V36 shares use the original P2PK donation script.
// V36+ shares use the combined P2SH 1-of-2 multisig script.
static std::vector<unsigned char> get_donation_script(int64_t share_version)
// BTC donation leg is forrestv's canonical P2PK on ALL share versions,
// including v36+ (FLAG6 conformance vs BTC's own jtoomim/forrestv baseline).
// The COMBINED P2SH script above is the LTC v36 donation target and is
// NEVER selected for BTC: returning it from a BTC gentx would pay the LTC
// dev-fund P2SH instead of forrestv's BTC-mainnet P2PK. The version arg is
// retained for signature parity with the LTC config but is ignored here.
static std::vector<unsigned char> get_donation_script(int64_t /*share_version*/)
{
if (share_version >= 36)
return {COMBINED_DONATION_SCRIPT.begin(), COMBINED_DONATION_SCRIPT.end()};
return {DONATION_SCRIPT.begin(), DONATION_SCRIPT.end()};
}

Expand Down
Loading