Skip to content

dgb: conform share/coin params to p2pool-dgb-scrypt oracle #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 2 commits into from
Jun 17, 2026
Merged

dgb: conform share/coin params to p2pool-dgb-scrypt oracle #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9accd5b
dgb: add make_coin_params factory (params.hpp) — Scrypt-only
frstrtr Jun 17, 2026
c51f39b
dgb: conform share/coin params to p2pool-dgb-scrypt oracle
frstrtr Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/impl/dgb/config_coin.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace config
} // config

/// DigiByte Scrypt coin parameters.
/// Source: p2pool-merged-v36/p2pool/bitcoin/networks/digibyte.py
/// Source of truth: p2pool-dgb-scrypt oracle bitcoin/networks/digibyte.py
///
/// DGB uses 5 algorithms rotating every 15 seconds. Scrypt is one of them.
/// When running as a P2Pool parent chain, we request getblocktemplate with
Expand All @@ -49,8 +49,10 @@ class CoinParams
static constexpr uint16_t MAINNET_RPC_PORT = 14024;
static constexpr uint16_t TESTNET_RPC_PORT = 14025;

// Block timing: 75s total / 5 algos = 15s per algo
static constexpr uint32_t BLOCK_PERIOD = 15; // seconds (Scrypt algo rotation)
// Block timing: Scrypt-only parent block period (oracle PARENT.BLOCK_PERIOD).
// DGB mints a block ~every 15s across 5 rotating algos; one algo (Scrypt)
// lands ~every 75s, which is the period a Scrypt-only parent observes.
static constexpr uint32_t BLOCK_PERIOD = 75; // seconds (Scrypt algo period)

// -----------------------------------------------------------------------
// Address encoding
Expand All @@ -71,7 +73,7 @@ class CoinParams

// -----------------------------------------------------------------------
// DGB subsidy schedule (3-phase decay)
// Source: p2pool-merged-v36/p2pool/bitcoin/networks/digibyte.py
// Source: p2pool-dgb-scrypt oracle bitcoin/networks/digibyte.py
// -----------------------------------------------------------------------
static uint64_t subsidy(uint32_t height)
{
Expand Down
20 changes: 10 additions & 10 deletions src/impl/dgb/config_pool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,21 @@ class PoolConfig : protected core::Fileconfig

// -----------------------------------------------------------------------
// Static DGB Scrypt p2pool network constants
// Source: p2pool-merged-v36/p2pool/networks/digibyte.py
// Source of truth: p2pool-dgb-scrypt oracle networks/digibyte.py
// -----------------------------------------------------------------------
static constexpr uint16_t P2P_PORT = 5024;
static constexpr uint32_t SPREAD = 30;
static constexpr uint32_t TARGET_LOOKBEHIND = 200;
static constexpr uint32_t SPREAD = 24;
static constexpr uint32_t TARGET_LOOKBEHIND = 100;
static constexpr uint32_t MINIMUM_PROTOCOL_VERSION = 1700; // floor (p2pool-dgb-scrypt digibyte.py NEW_MIN)
static constexpr uint32_t ADVERTISED_PROTOCOL_VERSION = 3301; // advertised capability (p2pool-dgb-scrypt p2p.py VERSION)
static constexpr uint32_t SEGWIT_ACTIVATION_VERSION = 17;
static constexpr uint32_t BLOCK_MAX_SIZE = 1000000;
static constexpr uint32_t BLOCK_MAX_WEIGHT = 4000000;
static constexpr uint32_t SEGWIT_ACTIVATION_VERSION = 35;
static constexpr uint32_t BLOCK_MAX_SIZE = 32000000;
static constexpr uint32_t BLOCK_MAX_WEIGHT = 128000000;

// Mainnet constants
static constexpr uint32_t SHARE_PERIOD = 25; // seconds
static constexpr uint32_t CHAIN_LENGTH = 8640; // ~24 hours at 25s
static constexpr uint32_t REAL_CHAIN_LENGTH = 8640;
static constexpr uint32_t SHARE_PERIOD = 15; // seconds (oracle SHARE_PERIOD)
static constexpr uint32_t CHAIN_LENGTH = 2880; // 12*60*60//15 — ~12h at 15s
static constexpr uint32_t REAL_CHAIN_LENGTH = 2880;

// Testnet constants
static constexpr uint32_t TESTNET_SHARE_PERIOD = 4;
Expand Down Expand Up @@ -124,7 +124,7 @@ class PoolConfig : protected core::Fileconfig
}

static inline const std::set<std::string> SOFTFORKS_REQUIRED = {
"csv", "segwit"
"nversionbips", "csv", "segwit", "reservealgo", "odo", "taproot"
};

// Bootstrap peers for the DGB Scrypt p2pool network
Expand Down
116 changes: 116 additions & 0 deletions src/impl/dgb/params.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
#pragma once

// DGB CoinParams factory: builds a fully populated core::CoinParams for the
// DigiByte-Scrypt p2pool parent chain.
//
// SOURCE OF TRUTH: the DGB oracle frstrtr/p2pool-dgb-scrypt (operator ruling
// 2026-06-17, "switch-oracle" / Option B). The V36-master byte-compat
// constraint with p2pool-merged-v36 is FORMALLY WAIVED for DGB by that ruling.
//
// CONSENSUS-NEUTRALITY: this factory holds NO hardcoded consensus bytes of its
// own. Every consensus-critical value is sourced from the single-source-of-truth
// static members of dgb::CoinParams (config_coin.hpp) and dgb::PoolConfig
// (config_pool.hpp), so there is exactly one place a DGB constant can drift.
//
// Scrypt-only (V36): pow_func = scrypt; other DGB algos are accept-by-continuity
// per project_v36_dgb_scrypt_only and never reach Scrypt share validation.

#include "config_coin.hpp"
#include "config_pool.hpp"

#include <core/coin_params.hpp>
#include <core/pow.hpp>

namespace dgb
{

inline core::CoinParams make_coin_params(bool testnet)
{
core::CoinParams p;

// ===== Coin-level (net.PARENT) — from dgb::CoinParams (config_coin.hpp) =====
p.symbol = "DGB";
p.block_period = CoinParams::BLOCK_PERIOD; // 75s (Scrypt-only parent period, oracle PARENT.BLOCK_PERIOD)

// Address encoding
if (testnet) {
p.address_version = CoinParams::TESTNET_ADDRESS_VERSION; // 126
p.address_p2sh_version = CoinParams::TESTNET_P2SH_VERSION; // 140
p.bech32_hrp = CoinParams::TESTNET_BECH32_HRP; // "dgbt"
} else {
p.address_version = CoinParams::ADDRESS_VERSION; // 30 (D...)
p.address_p2sh_version = CoinParams::ADDRESS_P2SH_VERSION; // 63 (S...)
p.bech32_hrp = CoinParams::BECH32_HRP; // "dgb"
}
// address_p2sh_version2: secondary P2SH prefix for parse leniency only, NOT
// block/share validation. The oracle defines a SINGLE P2SH version (63); it
// is silent on a second prefix, so 5 (DGB legacy) is NOT oracle-sourced.
// [confirm-vs-oracle] kept open — see oracle-conformance report.
p.address_p2sh_version2 = testnet ? 0 : 5;

// PoW: Scrypt work, SHA256d block identity (same shape as LTC)
p.pow_func = core::pow::scrypt;
p.block_hash_func = core::pow::sha256d;

// Subsidy: DGB 3-phase decay schedule (config_coin.hpp SSOT)
p.subsidy_func = [](uint32_t height) -> uint64_t {
return CoinParams::subsidy(height);
};

// Dust threshold: 0.001 DGB = 100000 sat. Confirmed vs oracle DUST_THRESHOLD
// (0.001e8). Local relay policy, not consensus.
p.dust_threshold = 100000;

// Softforks — from PoolConfig SSOT (oracle: nversionbips,csv,segwit,reservealgo,odo,taproot)
p.softforks_required = PoolConfig::SOFTFORKS_REQUIRED;
p.segwit_activation_version = PoolConfig::SEGWIT_ACTIVATION_VERSION; // 35

// ===== Pool-level (net) — from dgb::PoolConfig (config_pool.hpp) =====
p.p2p_port = PoolConfig::P2P_PORT; // 5024 (DGB sharechain P2P)
// worker_port: DGB Stratum port. Confirmed vs oracle WORKER_PORT = 5025.
// Operator-overridable via pool.yaml.
p.worker_port = 5025;

if (testnet) {
p.share_period = PoolConfig::TESTNET_SHARE_PERIOD; // 4
p.chain_length = PoolConfig::TESTNET_CHAIN_LENGTH; // 400
p.real_chain_length = PoolConfig::TESTNET_REAL_CHAIN_LENGTH; // 400
} else {
p.share_period = PoolConfig::SHARE_PERIOD; // 15
p.chain_length = PoolConfig::CHAIN_LENGTH; // 2880
p.real_chain_length = PoolConfig::REAL_CHAIN_LENGTH; // 2880
}

p.target_lookbehind = PoolConfig::TARGET_LOOKBEHIND; // 100
p.spread = PoolConfig::SPREAD; // 24
p.minimum_protocol_version = PoolConfig::MINIMUM_PROTOCOL_VERSION; // 1700 floor
p.block_max_size = PoolConfig::BLOCK_MAX_SIZE;
p.block_max_weight = PoolConfig::BLOCK_MAX_WEIGHT;

// Max target (share difficulty floor) — PoolConfig SSOT, testnet-aware
PoolConfig::is_testnet = testnet;
p.max_target = PoolConfig::max_target();

// Network identification — DGB oracle (switch-oracle Option B)
p.identifier_hex = PoolConfig::IDENTIFIER_HEX; // 4b62545b1a631afe
p.prefix_hex = PoolConfig::DEFAULT_PREFIX_HEX; // 1c0553f23ebfcffe
p.testnet_identifier_hex = PoolConfig::TESTNET_IDENTIFIER_HEX;
p.testnet_prefix_hex = PoolConfig::TESTNET_PREFIX_HEX;

// Bootstrap peers (populated as DGB p2pool nodes come online)
p.bootstrap_addrs = PoolConfig::DEFAULT_BOOTSTRAP_HOSTS;

// Donation scripts (consensus-critical) — version-gated selection lives in
// PoolConfig::get_donation_script (SSOT). v35 = forrestv P2PK (4104ffd0...),
// v36+ = combined P2SH 1-of-2.
p.donation_script_func = [](int64_t share_version) -> std::vector<unsigned char> {
return PoolConfig::get_donation_script(share_version);
};

p.current_share_version = 36;
p.is_testnet = testnet;

return p;
}

} // namespace dgb
Loading