Skip to content

dgb(tracker): derive chain-score time_span from CoinParams::block_period (drop farsider350 holdover) - #132

Closed
frstrtr wants to merge 1 commit into
dgb/oracle-conformancefrom
dgb/tracker-blockperiod-ssot
Closed

dgb(tracker): derive chain-score time_span from CoinParams::block_period (drop farsider350 holdover)#132
frstrtr wants to merge 1 commit into
dgb/oracle-conformancefrom
dgb/tracker-blockperiod-ssot

Conversation

@frstrtr

@frstrtr frstrtr commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Stacked on #131 (dgb/oracle-conformance).

What

best-chain score() computed time_span = block_height * 15 with a hardcoded 15s period and a dead farsider350 digibyte.py:21 comment. That bypassed the oracle-conformed PARENT.BLOCK_PERIOD (75s, config_coin.hpp set in #131). This sources it from the make_coin_params-populated m_params->block_period so there is ONE SSOT for the DGB Scrypt-only parent period in the score path — no hardcoded consensus holdover. Stale confirmation comments updated (1=tip -> 75s, ~75M fallback).

Bucket (v36 standardization)

PRE-V36 holdover removal -> conform to own oracle frstrtr/p2pool-dgb-scrypt. Coin-specific consensus value; per-coin, not a cross-coin standardization target.

Scope / safety

  • dgb-only (src/impl/dgb/share_tracker.hpp); no shared-base / bitcoin_family touch.
  • c2pool-dgb builds clean (EXIT=0, binary links). NOTE: share_tracker.hpp is header-only and not yet pulled into a compiled TU (node is still the skeleton; the pool layer that instantiates the tracker lands in the stacked pool/share slices) — so the line is not compile-exercised by the current smoke. It is valid in the context it will compile (m_params is an established member, block_period a CoinParams field).

NO AI/model attribution. GPG-signed (c0ea7c7).

The best-chain score() hardcoded a 15s block period (a dead farsider350
digibyte.py holdover) for time_span = block_height * BLOCK_PERIOD, bypassing
the oracle-conformed PARENT.BLOCK_PERIOD (75s, config_coin.hpp). Source it
from the make_coin_params-populated m_params->block_period so there is one
SSOT for the DGB Scrypt-only parent period and no hardcoded consensus
holdover in the score path. Stale confirmation comments updated (1=tip->75s).
@frstrtr

frstrtr commented Jun 18, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #145 (DGB Phase-B batch land #132->#142, operator-approved merge-as-reviewed; content incl. this PR verified present in the batch). Landed to master via #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant