dgb(tracker): derive chain-score time_span from CoinParams::block_period (drop farsider350 holdover) - #132
Closed
frstrtr wants to merge 1 commit into
Closed
Conversation
The best-chain score() hardcoded a 15s block period (a dead farsider350 digibyte.py holdover) for time_span = block_height * BLOCK_PERIOD, bypassing the oracle-conformed PARENT.BLOCK_PERIOD (75s, config_coin.hpp). Source it from the make_coin_params-populated m_params->block_period so there is one SSOT for the DGB Scrypt-only parent period and no hardcoded consensus holdover in the score path. Stale confirmation comments updated (1=tip->75s).
This was referenced Jun 17, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #131 (dgb/oracle-conformance).
What
best-chain score() computed time_span = block_height * 15 with a hardcoded 15s period and a dead farsider350 digibyte.py:21 comment. That bypassed the oracle-conformed PARENT.BLOCK_PERIOD (75s, config_coin.hpp set in #131). This sources it from the make_coin_params-populated m_params->block_period so there is ONE SSOT for the DGB Scrypt-only parent period in the score path — no hardcoded consensus holdover. Stale confirmation comments updated (1=tip -> 75s, ~75M fallback).
Bucket (v36 standardization)
PRE-V36 holdover removal -> conform to own oracle frstrtr/p2pool-dgb-scrypt. Coin-specific consensus value; per-coin, not a cross-coin standardization target.
Scope / safety
NO AI/model attribution. GPG-signed (c0ea7c7).