dgb: M3 wire external-daemon RPC transport into build + real ctor - #151
Merged
Conversation
The M3 RPC transport (rpc.cpp + rpc_request/softfork SSOTs) landed as additive coin-layer source in #149 but was never registered in CMake, so it never compiled into the build, and the node owner still constructed the 1-arg stub ctor. This closes that deferred Option-B wiring. - coin/CMakeLists.txt: add rpc.cpp + rpc_request.hpp + softfork_check.hpp to dgb_coin_impl so the transport TU is compiled and linked. - coin/node.hpp: capture the io_context in the Node ctor and construct the real NodeRPC(m_context, this, m_config->m_testnet), replacing the stub. This is the external-daemon FALLBACK path V36 mandates persists alongside the embedded daemon; testnet drives NodeRPC::check()s chain-identity
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M3 — wire external-daemon RPC transport into the build
Closes the deferred Option-B wiring from #149. The M3 RPC transport (
rpc.cpp+ therpc_request.hpp/softfork_check.hppSSOTs) landed as additive coin-layer source in #149 but was never registered in CMake, so it never compiled into the build — and the node owner still constructed the 1-arg stubNodeRPC.Changes (src/impl/dgb/ only)
rpc.cpp+rpc_request.hpp+softfork_check.hpptodgb_coin_implso the transport TU compiles and links.io_contextin theNodector and construct the realNodeRPC(m_context, this, m_config->m_testnet), replacing the stub. This is the external-daemon FALLBACK path V36 mandates persists alongside the embedded daemon;testnetdrivesNodeRPC::check()chain-identity genesis probe.Verification (local)
dgb_coin+c2pool-dgbbuildEXIT=0(rpc.cpp now compiles intolibdgb_coin.a, exe links).CI notes
rpc.cppcompiles via the existing dgb smoke (buildsc2pool-dgb→ linksdgb_coin).p2pool-dgb-scrypt parity preserved. HOLD merge for operator push-approval.