dgb: delegate V36 version-gate sites to core::version_gate SSOT (#148) - #159
Merged
Conversation
Replace DGB per-coin "version >= 36" share-format/consensus gate literals with core::version_gate::is_v36_active(), mirroring the BTC reference adoption site-for-site (33 sites: share.hpp x6, share_tracker.hpp x1, share_check.hpp x26). Pure-mechanical V37-standardization delegation: the gate boundary stays the uniform cross-coin 36, behavior byte-identical. Only positive >=36 gate sites are delegated; inverse forms (version < 36, share_version <= 35, m_desired_version < 36) and BaseShare<36> template args are left verbatim, matching BTC. Donation-script gate (config_pool) untouched -- that is the separate core::donation delegation. Closes the DGB slice of the cross-coin version_gate standardization tail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Points DGB per-coin V36 version-gate call sites at the merged
core::version_gateSSOT (is_v36_active, #148 @ebfb9609), mirroring the BTC reference adoption site-for-site.Sites delegated (33, = BTC count)
share.hppx6 —if constexpr (version >= 36)share_tracker.hppx1 — runtimeshare_vergateshare_check.hppx26 — ref-serialization gates, PPLNS-formula select, log guards, constexpr branchesPure-mechanical / byte-identical
The V36 boundary stays the uniform cross-coin
36; this only re-points the literals at the one SSOT — no semantic change.>= 36gate sites delegated.version < 36,share_version <= 35,m_desired_version < 36(distinct field), andBaseShare<36>template args.config_pool) left untouched — that is the separatecore::donationdelegation (FLAG6), not this task.No coin-specific divergence found vs
core::version_gate(per the #161 inst#4 caution).Scope
DGB-only. Orthogonal to in-flight #158 (M3 scrypt-digest, touches coin/header_chain + tests).
Verification
-DCOIN_DGB=ON+ buildc2pool-dgb+dgb_share_test: EXIT=0dgb_share_test: 5/5 PASSc2pool-dgb --selftest: OKNo self-merge — HOLD for integrator verify-vs-core + operator tap.