dash(S7): block-subsidy + UTXO adapter foundation leaf - #169
Merged
Conversation
Adds src/impl/dash/coin/subsidy.hpp (GetBlockSubsidy + masternode/platform reward split) and the header-only utxo_adapter.hpp view shim, with test_dash_subsidy.cpp (8 oracle-conformance KATs against mainnet heights 2459985/2470904). Header-only over block/transaction + core/coin (utxo_view_cache/db); no ltc/pool SCC dependency. Registered in the CI --target lists so it builds under dash-linux-only. Foundation prerequisite for the embedded_gbt template builder (S7 main).
frstrtr
added
the
dash-linux-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S7 foundation slice off new master 7364408 (#165 landed).
What: adds
src/impl/dash/coin/subsidy.hpp(GetBlockSubsidy + masternode/platform reward split) and the header-onlyutxo_adapter.hppview shim, plustest_dash_subsidy.cpp(8 oracle-conformance KATs vs mainnet heights 2459985 / 2470904).Why first:
embedded_gbt.hpp(S7 main, the getblocktemplate-equivalent builder) transitively needs 6 absent dash headers; subsidy is the dependency-free base of that chain. Slicing it first keeps each PR self-contained and verifiable.Safety: header-only over block/transaction + core/coin (utxo_view_cache/db); no ltc/pool SCC dependency; no API removal. dashd-RPC fallback path untouched. Registered in both build.yml --target lists (CI builds it; unconditional-in-CMake != built).
Verify (Linux x86_64, .198): configure green;
cmake --build --target test_dash_subsidygreen;ctest -R DashSubsidy= 8/8 passed (real count, run from build/).