dgb(#82): wire CoinParams::subsidy_func into embedded coinbasevalue SSOT - #188
Merged
Merged
Conversation
frstrtr
force-pushed
the
dgb/subsidy-func-embedded-coinbasevalue
branch
from
June 19, 2026 07:51
0405125 to
82eca8e
Compare
Adds src/impl/dgb/coin/embedded_coinbase_value.hpp: the single place the DGB CoinParams::subsidy_func feeds a live coinbase-build path. Until now subsidy_func was populated in params.hpp (oracle-conformed) but had zero invocation sites; the live path only read m_coinbase_value off external-daemon GBT. embedded_coinbase_value(subsidy_func, height, fees) = subsidy_func(height)+fees, mirroring ltc/coin/template_builder.hpp coinbasevalue = subsidy + total_fees but sourcing the subsidy through the CoinParams SSOT (oracle decay schedule). resolve_coinbase_value() preserves the external-daemon fallback: a present GBT coinbasevalue is authoritative and returned verbatim; the embedded derivation is used only when no external daemon supplies one. Unset subsidy_func throws loudly. test/test_dgb_coinbase_value.cpp: 4-era boundary conformance through the subsidy_func indirection + fee composition + GBT-precedence + unset-throws (5/5). Registered in test/CMakeLists.txt and both build.yml --target allowlists (#143). Single-coin; no bitcoin_family/src/core/sibling-coin touch. External-daemon GBT path unchanged.
frstrtr
force-pushed
the
dgb/subsidy-func-embedded-coinbasevalue
branch
from
June 19, 2026 08:04
82eca8e to
0754cca
Compare
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-only #82 embedded-wiring TODO (integrator 2026-06-18): wire CoinParams::subsidy_func(height)+fees into the embedded coinbase builder + a 4-era boundary conformance test, with the external-daemon GBT fallback preserved.
What
Isolation / CI
Note
Header-only SSOT + guard test. The live call-site binding (work_source.cpp Stage 4c TemplateBuilder consumes this helper for its coinbasevalue) lands with the Stage 4c template build; this slice establishes the single definition both the embedded and GBT paths resolve through.
HOLD merge — integrator merges on operator push-approval.