nmc(P1e): activation-height admission gate + 4 KATs (stacked on #189) - #190
Merged
Merged
Conversation
check_activation_gate(height, has_auxpow) -> AdmitResult: below activation an AuxPow is premature, at/after activation (mainnet) it is mandatory; refuses to judge (REJECT_UNPINNED) while auxpow_activation_height stays the -1 sentinel so no verdict is rendered off a placeholder. Factored like the P1d verify_auxpow_header gate so it is unit-testable independent of the still-deferred storage path. +4 KATs (30->34), rides the existing build.yml-allowlisted nmc_auxpow_merkle_test target. NMC-only under src/impl/nmc/, btc tree READ-ONLY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #189 (P1d gate). Factors HeaderChain::check_activation_gate(height, has_auxpow) -> AdmitResult, the height-derived merge-mining activation gate, mirroring the P1d verify_auxpow_header pattern so it is unit-testable without the still-deferred storage path.
Rules enforced:
+4 KATs (30 -> 34, all green local) under NmcP1eActivationGate; rides the existing build.yml-allowlisted nmc_auxpow_merkle_test target (no CMake/CI change). NMC-only under src/impl/nmc/; btc tree READ-ONLY. Production activation height/chain-id stay TO-CONFIRM unpinned.