nmc(P1e): work-based reorg fork-choice (+6 KATs, 46->52) - #197
Merged
Conversation
connect_locked now selects the tip by most-cumulative-work (with an equal-work tie-break at the tip height) instead of greatest-height, mirroring btc::coin::HeaderChain. A heavier competing branch reorgs the tip even when shorter; an equal-work sibling at the tip height switches (network-consensus tie-break for min-difficulty testnet). Idempotent reject of known hashes makes the switch flip-flop-proof. New NmcP1eForkChoice suite: heavier-short-branch reorg, lighter-sibling no-reorg, equal-work switch, re-receive stability, post-reorg extend, first-header-is-tip. nmc_auxpow_merkle_test 52/52 PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HeaderChain::connect_lockednow selects the chain tip by most cumulative work (with an equal-work tie-break at the tip height), not greatest height — mirroringbtc::coin::HeaderChain. Closes the last P1e fork-choice sub-leg; the prior leg only summed work, tip selection stayed height-proxy.[EMB-NMC] REORG/EQUAL-WORK REORGlog on branch switch.Tests
New
NmcP1eForkChoicesuite (6 KATs): heavier-short-branch reorg, lighter-sibling no-reorg, equal-work switch, re-receive stability, post-reorg extend, first-header-is-tip.nmc_auxpow_merkle_test52/52 PASS (was 46). Build green; rides the allowlisted target, no CI change.Scope
NMC tree only (
src/impl/nmc/coin/header_chain.hpp+ test). No cross-coin, no sharedsrc/core.