nmc(P1f-a): canonical CAuxPow Serialize + persist auxpow blob behind has_auxpow - #202
Merged
Conversation
…has_auxpow Port the Namecoin CAuxPow wire layout to nmc::coin::AuxPow::Serialize/Unserialize (CMerkleTx coinbase leg -> chain-merkle leg -> parent header, daemon field order; parent coinbase TX_NO_WITNESS to match the committed txid). Persist the blob in IndexEntryDiskV1 behind has_auxpow and restore it in to_entry(); the deferred flag-only leg is removed. Fenced to src/impl/nmc/ only. +2 KATs (codec round-trip + still-VALID; IndexEntryDiskV1 blob round-trip) and the #201 deferred-blob test updated to assert restoration. 64->66 green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-leg (a) of NMC P1f, per integrator GO (port the canonical Namecoin CAuxPow wire layout, fenced to src/impl/nmc/). Stacked on #201.
What
Fence
Touches src/impl/nmc/ only — no bitcoin_family/ or src/core/. Target nmc_auxpow_merkle_test already in build.yml allowlist (no CI change).
Consensus note / merge handling
Adds a consensus serialization shape — per integrator this does NOT auto-merge: CI-verify, then operator tap. Immediate follow-up: ground-truth wire-vector assertion serializing a captured Namecoin testnet auxpow and asserting the daemon bytes (KAT currently self-round-trips + verifies).