dgb: #82 arm2 — bind sharechain m_on_block_found to won-block dispatcher - #205
Merged
Conversation
Install tracker().m_on_block_found in main_dgb.cpp --run via make_on_block_found, routing a pool-found parent block through broadcast_won_block dual-path. coin_node seam hoisted above p2p_node so it outlives the tracker callback; shared with the Stratum submit arm. reconstruct closure is the documented interim (returns nullopt with a loud [DGB-POOL-BLOCK] log) — a won share is announced/audited, never silently dropped, and no malformed block is emitted. Faithful reconstruct_won_block + embedded P2pRelaySink land with the Phase B embedded template builder. #82 stays open: won-block-reaches-network is proven only via the live external-digibyted submitblock fallback (the Stratum arm), not this binding alone. Fenced to src/c2pool/main_dgb.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the sharechain (pool) won-block arm of #82 dual-path broadcaster in
main_dgb.cpp --run.tracker().m_on_block_found = make_on_block_found(reconstruct, P2pRelaySink{}, &coin_node)— a pool-found parent block now routes throughbroadcast_won_blockinstead of being silently dropped (the dgb: v36 donation version-gate (pillar 4 of modern-layer activation) #82 root cause).coin_nodeseam hoisted abovep2p_nodeso it outlives the tracker callback; shared with the existing Stratum submit arm.reconstructis the documented interim: returnsnulloptwith a loud[DGB-POOL-BLOCK]log — won share announced/audited, no malformed block emitted. Faithfulreconstruct_won_block+ embeddedP2pRelaySinkland with the Phase B embedded template builder.#82 stays OPEN per integrator guardrail (2): won-block-reaches-network is proven only via the live external-digibyted submitblock fallback (Stratum arm), NOT this binding alone.
Fenced to
src/c2pool/main_dgb.cpp. Build EXIT=0, --run standup smoke OK.