nmc: P1 PB embedded mempool (re-homed btc mirror) - #210
Merged
Conversation
Adds nmc::coin::Mempool — a byte-faithful mirror of src/impl/btc/coin/ mempool.hpp re-homed into namespace nmc::coin so the NMC coin tree stays self-contained (no btc::coin symbols). Namecoin is a Bitcoin fork: same wire format, 21M money cap, 100-block coinbase maturity (NMC_LIMITS, instantiated locally from the public core::coin::ChainLimits; no core edit). Feeds the P1 PC template builder next. Coverage: +3 KATs in the existing (CI-allowlisted) nmc_auxpow_merkle_test (add/contains/remove + dedup, feerate-ordered selection, confirmed-block cleanup). Suite 66 -> 69 green. Fence held: src/impl/nmc/ only, no build.yml / src/core / bitcoin_family change. Reference: namecoin-core (Bitcoin fork) txmempool.cpp / amount.h MAX_MONEY, consensus.h COINBASE_MATURITY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 PB — NMC embedded mempool
Adds
nmc::coin::Mempool(src/impl/nmc/coin/mempool.hpp): a byte-faithful mirror of the btc pool re-homed intonamespace nmc::coinso the NMC coin tree stays self-contained (nobtc::coinsymbols), matching the existing transaction.hpp/block.hpp/header_chain.hpp pattern. Unlike DOGE (which aliasesltc::coin::Mempool), NMC keeps the re-homed convention already established across P0/P1.Namecoin is a Bitcoin fork — same wire format. Money params come from a locally-instantiated
NMC_LIMITS(core::coin::ChainLimits= 21M*1e8 sat, 100-block coinbase maturity, no pegout); nosrc/coreedit.Coverage
+3 KATs in the existing CI-allowlisted
nmc_auxpow_merkle_test(no build.yml change, no NOT_BUILT sentinel):remove_for_block)Local: build green; suite 66 -> 69 PASS.
Fence
src/impl/nmc/only. Nosrc/core, nobitcoin_family/, no.github/. Next: P1 PC template builder consumes this pool.Reference: namecoin-core (Bitcoin fork) txmempool.cpp / amount.h MAX_MONEY, consensus.h COINBASE_MATURITY.