[CI-VERIFY - DO NOT MERGE] dgb stage-4 stack (#216/#217/#219) full-matrix signal - #220
Closed
frstrtr wants to merge 3 commits into
Closed
[CI-VERIFY - DO NOT MERGE] dgb stage-4 stack (#216/#217/#219) full-matrix signal#220frstrtr wants to merge 3 commits into
frstrtr wants to merge 3 commits into
Conversation
…rk template (Stage 4c) HeaderSample gains a sha256d block-id slot (block_hash, u256; 0 == not populated here, the same sentinel pow_hash uses) and HeaderChain gains a tip_hash() accessor returning the newest header's id or nullopt when the chain is empty / the tip carries no hash. get_current_work_template emits previousblockhash as GBT-conventional big-endian display hex ONLY when tip_hash() is present -- a truthful conditional, never a fabricated hash. The embedded P2P header-download -> validate_and_append ingest that populates block_hash lands in a following slice; until then tip_hash() is nullopt and previousblockhash is held back exactly as before. bits stays HELD BACK: the only embedded next-target source is the DigiShield damped multiply, which DGB Core runs as MultiShield V4 (a global window across all 5 algos == V37); a Scrypt-only walk cannot reconstruct it, so the ingest path demotes that gate to a no-op. Emitting a digishield-derived bits would be a known-wrong value. The authoritative bits is the external-daemon GBT value, not plumbed into this embedded path yet -- surfaced as [decision-needed]. Fenced to src/impl/dgb (4 files); test cases added to existing targets header_chain_test (31 -> 35) and dgb_work_source_test (15 -> 16), no new gtest target so the build.yml allowlist is unchanged. Both green.
The Stage-4b prevhash getter still returned {} while get_current_work_template
emits previousblockhash from chain_.tip_hash() (#216). Route the getter through
the SAME tip_hash() accessor and u256_be_display_hex formatter so the dedicated
getter and the assembled template cannot silently diverge: one truthful source.
Empty string when tip_hash() == nullopt (empty chain / unpopulated block_hash
sentinel) -- a truthful absence, never a fabricated id. Non-consensus read-only
getter, fenced to src/impl/dgb. +1 test asserting getter == template field on a
seeded tip and joint-absence with no tip; dgb_work_source_test 17/17.
…age 4c) Lift the GBT-shaped template assembly out of DGBWorkSource::get_current_work_template() into a free function dgb::coin::build_work_template() in coin/template_builder.hpp, so the stratum work source and the embedded path emit ONE template object and cannot diverge. Pure non-consensus shaping: the consensus-bearing coinbasevalue is still resolved by the caller through the #207 resolve_coinbase_value -> subsidy_func SSOT and passed in verbatim; the builder never recomputes or scales it. version (Scrypt lane pin via DGB_BLOCK_VERSION_SCRYPT), mintime (MTP+1, 0 on empty chain), curtime, empty transactions[] and the truthful conditional previousblockhash all move into the builder unchanged. bits stays held back (MultiShield V4 next-target is V37). Behaviour-preserving: dgb_work_source_test 17/17 unchanged (incl the prevhash getter == template field joint-absence assertion). New guard-weight dgb_template_builder_test 7/7 pins the invariants (Scrypt pin, coinbasevalue pass-through, mintime/empty-chain, empty transactions + no bits, prevhash conditional, determinism). Wired into ctest + both build.yml allowlists (#143 NOT_BUILT trap avoided).
Owner
Author
|
Superseded: #220 came up DIRTY (stack predates current master, build.yml allowlist conflict) so pull_request CI cannot build a merge commit. Replaced by a master-based merge-resolution branch ci-steward/dgb-stage4-ci-verify with the allowlist unioned — see the new CI-VERIFY PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. CI-signal-only PR opened by ci-steward.
Purpose: PRs #216/#217/#219 are a stacked chain whose base refs
(dgb/stage-4c-gbt-scaffold-fields -> ...-prevhash-accessor -> ...-prevhash-getter)
are NOT in build.yml pull_request.branches allowlist, so the matrix never
enqueued. gh pr checks = "no checks reported"; mergeStateStatus=CLEAN only
means no merge conflict, NOT green.
This PR targets master (which IS filtered) with the cumulative stack head
dgb/stage-4c-template-builder-ssot to obtain the missing CI rollup
(Linux / ASan / Windows) and specifically to prove #219 build.yml wiring
compiles + runs the new dgb_template_builder_test target with no #137-class
NOT_BUILT sentinel.
Individual fenced slices (#216/#217/#219) remain the integrator-routed merges;
close this verification PR once signal is captured.