test: deflake middleware error-taxonomy smoke (disable retry in fixture) - #235
Merged
Merged
Conversation
…fter sleep) The error-taxonomy normalisation test threw a 429 with retryAfter:2000 and left core.transport.retry enabled with maxAttempts:1. retry.ts honours the server Retry-After via Math.max(delay, retryAfterMs), so the single retry slept the full 2000ms before the terminal throw, parking the test on the CI per-test deadline (deterministic, survives re-run). The test subject is error normalisation, not retry; disable core.transport.retry so the normalised rate_limited error (retryAfterMs:2000 still asserted) propagates in ~ms. Product retry behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Web-static verify flake blocking the DGB embedded-ingest stack (#227->#230).
Root cause (explorer-merged triage): smoke.test.ts "Middleware chain: error-taxonomy normalises thrown errors" throws a 429 with retryAfter:2000 while leaving core.transport.retry enabled at maxAttempts:1. retry.ts honors server Retry-After, so the single retry sleeps the full 2000ms and parks on the 2s per-test deadline — deterministic, not flaky. Product code is correct; only the fixture was wrong.
Fix: the test subject is error normalisation, not retry, so retry is disabled for this fixture. rate_limited / retryAfterMs===2000 assertions still hold; runtime drops from 2007ms to ~ms.
Verified on workstation: full npm run verify green (257 tests, 245 pass, 0 fail), no test over 1500ms. GPG-signed, off origin/master.
SHA: d67e7c8
EXECUTOR: integrator (merge on operator approval)