bch(M5): --with-peer-verify — live VM300 won-block P2P leg + forced-stall reissue proof - #236
Merged
Merged
Conversation
frstrtr
force-pushed
the
bch/m5-with-peer-verify
branch
from
June 19, 2026 22:22
b7dda42 to
a1f31da
Compare
frstrtr
force-pushed
the
bch/m5-with-peer-verify
branch
from
June 19, 2026 23:09
a1f31da to
1160bdd
Compare
… forced-stall reissue Closes the end-to-end gap PR #231 (production run() arming the embedded P2P leg via maybe_start_p2p) left open: its offline step7 test only proves the no-peer RPC-only contract. This adds a co-located, strictly read-only WITH-peer mode against the live VM300 bchn-bch peer proving the two positives: (a) arm_p2p_no_rpc() = run() minus init_rpc drives the REAL maybe_start_p2p() through its configured-peer gate; broadcast_route() reports p2p -> the won-block dispatcher SELECTS the embedded P2P relay leg, not the RPC-only fallback. Routing asserted via a dry sink-selection read (broadcast_route), no block relayed onto mainnet. (b) a forced download-window stall (one unservable hash enqueued through request_block_downloads, the connector deep-reorg re-request sink) makes reissue_count() go nonzero off the LIVE window after BLOCK_DL_TIMEOUT, not the synthetic tick the unit test uses. Live result @VM300 192.168.86.110:8333 (BCHN 29.0.0, start_height 956031, compact-blocks v1): armed=yes route_p2p=yes reissue 0->1 at t=70s -> ALL PASS. Fenced src/impl/bch/ + binary entrypoint only; transport/local block-dl wiring, no PoW/share/coinbase/PPLNS change. p2pool-merged-v36 surface: NONE.
frstrtr
force-pushed
the
bch/m5-with-peer-verify
branch
from
June 20, 2026 01:16
1160bdd to
1833bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #231 (bch/m5-run-p2p-leg). Closes the WITH-peer end-to-end gap #231 step7 could not reach.
Live result @VM300 bchn-bch 192.168.86.110:8333 (BCHN 29.0.0, start_height 956031, compact-blocks v1), read-only:
arm_p2p_no_rpc()(run() minus init_rpc) armed the realmaybe_start_p2p();broadcast_route()==p2p-> won-block dispatcher selects the embedded P2P relay leg, NOT the RPC-only fallback. No block relayed onto mainnet (dry sink-selection read).request_block_downloads, the connector deep-reorg re-request sink) drovereissue_count0 -> 1 at t=70s off the live window after the 60s BLOCK_DL_TIMEOUT — not the synthetic tick the unit test uses.armed=yes route_p2p=yes reissue=1-> with_peer_verify: ALL PASS.Fence: src/impl/bch/ + binary entrypoint only; transport/local block-dl wiring. p2pool-merged-v36 surface: NONE. GPG-signed.
--with-peer-verifyneeds a live peer so it is a co-located manual mode (like leg-C), not a CI CTest; the binary builds under the COIN_BCH CI leg. §5.3 evidence appended to c2pool-bch-embedded-divergence-set.md (frstrtr/the, push operator-gated).