nmc: P1 PE 2b-i — register NMC P2P port in host get_coin_p2p_port (RPC-first cid=1) - #238
Merged
Merged
Conversation
… PE 2b-i) RPC-first leg of NMC cid=1 merged-mining registration. The --merged NMC:1:host:port:user:pass spec already rides the chain_id-generic add_chain + submitblock RPC-fallback path; this adds the only host hunk that leg needs: the NMC well-known P2P port so auto-port wiring resolves. Port sourced from src/impl/nmc/coin/chain_seeds.hpp SSOT (harvested live from a namecoind addrman), not retyped from memory. The get_chain_p2p_prefix NMC magic case is intentionally deferred: the network pchMessageStart is not yet pinned in the nmc SSOT, so the fast P2P relay leg lands with the embedded backend in 2b-ii. DOGE(98)/LTC untouched and byte-isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1 PE leg 2b-i (RPC-first ordering). Single additive host hunk: NMC well-known P2P port (8334 mainnet / 18334 testnet) in get_coin_p2p_port.
Why minimal: the chain_id-generic merged path already admits NMC on cid=1 —
--merged NMC:1:host:port:user:passparses generically (spec parser stoul(parts[1])) and registers via add_chain + submitblock RPC-fallback with no host change. This commit adds the only host hunk the RPC-first leg needs.Sourcing: port from src/impl/nmc/coin/chain_seeds.hpp SSOT (harvested live from a namecoind addrman), not memory.
Deferred (by design): get_chain_p2p_prefix NMC magic case — network pchMessageStart not yet pinned in nmc SSOT (daemon-gate); the fast P2P relay leg lands with the embedded backend in 2b-ii.
DOGE(98)/LTC byte-isolated, no build.yml. Shared host file -> NOT auto-merge-fenced; operator tap on full-rollup green. I do not self-merge.