ci: generic test-allowlist drift-guard (NOT_BUILT fail-closed) - #266
Merged
Conversation
Add tools/ci/check_test_target_allowlist.py + a standalone, build-free CI job that fails closed when a per-coin test executable declared in src/impl/<coin>/test/CMakeLists.txt is absent from the build.yml --target allowlist. Such a target is never compiled, so CTest reports it NOT_BUILT and silently passes -- the DGB #137 / test_dgb_subsidy class that red'd master. Generic across all coin lanes (bch/btc/dgb/ltc/nmc); expands foreach(t IN LISTS VAR) + add_executable(prefix_${t}) generators. Escape hatch for intentionally unbuilt targets: # ci-allowlist-exempt: <target> -- <reason>. Currently audits 48 targets across 5 lanes, all present (zero drift).
frstrtr
added a commit
that referenced
this pull request
Jul 26, 2026
…->v36 flip (#876) Pins the donation script SSOT (core::donation::get_donation_script) byte-for-byte on both legs: v<36 = 67-byte BCH current-mainnet forrestv P2PK (guarded against a silent LTC/DASH-copied vector via the pubkey-prefix identity check), v>=36 = 23-byte combined 1-of-2 P2SH. Boundary pinned EXACTLY at version 36 (no off-by-one byte-offset-104 GENTX divergence). Guards the only G2-ratchet failure mode that is silent and reward-losing. Header-only, rig-free, gate-logic untouched. Wired into BCH_ABLA_TESTS and both build.yml COIN_BCH target lists; local ctest #266 PASS. Co-authored-by: frstrtr <frstrtr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone, build-free CI job + tools/ci/check_test_target_allowlist.py that fails closed when a per-coin test executable declared in src/impl//test/CMakeLists.txt is absent from the build.yml
--targetallowlist.Why: such a target is never compiled, so CTest reports it NOT_BUILT and silently passes — the DGB #137 / test_dgb_subsidy class that red'd master at 4284fda. This guards that failure mode at PR time.
Scope (per integrator green-light):
foreach(t IN LISTS VAR)+add_executable(prefix_\${t})generators (bch ABLA + embedded-body suites).# ci-allowlist-exempt: <target> -- <reason>.Verification:
Touches shared build.yml → operator-tap, not auto-merge/fenced lane.