Skip to content

ltc: fix NodeRPC::Send UAF (thread-race on shared HTTP client) — .157 crash-loop ship-blocker #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frstrtr merged 1 commit into from
Jun 20, 2026
Merged

ltc: fix NodeRPC::Send UAF (thread-race on shared HTTP client) — .157 crash-loop ship-blocker #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/impl/ltc/coin/rpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ void NodeRPC::sync_reconnect()

std::string NodeRPC::Send(const std::string &request)
{
std::lock_guard<std::mutex> _rpc_lock(m_rpc_mutex);
// Retry once after synchronous reconnect on write/read failure
for (int attempt = 0; attempt < 2; ++attempt)
{
Expand Down
6 changes: 6 additions & 0 deletions src/impl/ltc/coin/rpc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "node_interface.hpp"

#include <iostream>
#include <mutex>

#include <core/uint256.hpp>
#include <core/timer.hpp>
Expand Down Expand Up @@ -38,6 +39,11 @@ class NodeRPC : public jsonrpccxx::IClientConnector
beast::tcp_stream m_stream;
boost::asio::ip::tcp::resolver m_resolver;
http::request<http::string_body> m_http_request;
// Serializes Send(): m_http_request + m_stream are NOT thread-safe. The asio
// thread_pool worker (clean_tracker->think->score->getblockheader) and the main
// thread both drive Send() on this single shared client; without this lock T0's
// prepare_payload() frees the Content-Length field element mid-write on T8 -> UAF.
std::mutex m_rpc_mutex;

std::unique_ptr<RPCAuthData> m_auth;
jsonrpccxx::JsonRpcClient m_client;
Expand Down
Loading